Runtime adapters
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by separating the listed runtimes and concerns: caching, network calls, child processes, progress, filesystems, and mounts. Read the linked issues 46 and WordPress Playground issue 1026; the payload names no implementation files or tests, so the first milestone is agreeing on scope and runtime boundaries before defining what done means.
Written by the indexing model from the issue text.
Description
Blueprints should support at least the following runtimes:
- wp-cli
- Docker
- wp-now
- Playground
- Native PHP CLI
- VS Code extension
Runtime-specific features
Caching the downloads
Blueprints shouldn't download the same 10MB WordPress.zip twice. Let's make sure we cache the downloads and invalidate the entries as new versions of Core and Plugins are released.
- In native PHP CLI, we can cache in the filesystem, e.g.
~/.wp/. Ideally, this would take HTTP headers into consideration. - In Playground, we can rely on HTTP cache built into
fetch(). In addition, we could cache at the service worker level. - In VS Code, there's a caching API AFAIR.
- In Docker, we could use the docker build layers for caching.
Network calls
- In native PHP CLI, we can use
libcurlorfopen("https://") - In Playground, we can only rely on
fetch(). We can't open raw TCP sockets sofopen("https://")andlibcurlcannot be easily used. - In VS Code, we can open raw TCP sockets so
fopen("https://"), butlibcurlisn't since Playground doesn't support it yet.
Spawning child processes
Blueprint steps, wp-cli, phpunit, and other tools will often spawn child processes.
- In wp-now PHP and native PHP, we can rely on
proc_open - In Playground, we need a custom spawn handler implemented in JavaScript
Reporting progress
- In any CLI, we should display an ASCII progress bar.
- With Docker as a backend, we should report the build progress somehow.
- In Playground, progress bar is a
<div>that needs to change itswidthsandinnerText
Filesystem interactions
I'd love to avoid abstract the filesystem and just use the regular PHP functions like copy() and fread()
Local mounts
It may useful to support mounting directories
- In the browser, we would either bale out (with a warning?) or mount an OPFS directory, whether that's page-specific or a local directory handle
- In wp-now and Docker, we can mount directories in the runtime without changing anything on the disk
- In Native PHP we could use symlinks
Technical implementation
Dependency injection
Let's explore the dependency injection pattern. Pimple is a tiny service container we can use to plug-in runtime-specific implementations:
$container = new Container();
switch ( $runtime ) {
case self::RUNTIME_NATIVE:
$container['downloads_cache'] = function ( $c ) {
return new FileCache();
};
$container['http_client'] = function ( $c ) {
return HttpClient::create();
};
$container['progress_reporter'] = function ( $c ) {
return function ( ProgressEvent $event ) {
echo $event->url . ' ' . $event->downloadedBytes . '/' . $event->totalBytes . " \r";
};
};
break;
case self::RUNTIME_PLAYGROUND:
$container['downloads_cache'] = function ( $c ) {
// @TODO
};
$container['http_client'] = function ( $c ) {
// @TODO
};
$container['progress_reporter'] = function ( $c ) {
// @TODO
// post_message_to_js();
};
break;
Other ideas
What are other viable solutions to this problem?
- Dominant language
- PHP
- Stars
- 61
- Forks
- 22
- Avg merge
- 19h 34m
- Merged PRs (30d)
- 7
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from WordPress/php-toolkit
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
WordPress/php-toolkit#313 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
WordPress/php-toolkit#306 ·
-
WPCS complianceOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
WordPress/php-toolkit#157 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
WordPress/php-toolkit#138 · 7 comments · 2 reactions ·
-
[Blueprints v2] Constraint the Blueprint bundle formatMay be free again @JanJakes claimed this 431 days ago, and no pull request is open. OpenBlueprints enhancement
WordPress/php-toolkit#132 · 4 comments · 1 assignee ·
All issues in WordPress/php-toolkit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
filamentphp/filament#20630 ·
Maintainers usually reply within 1 day
-
Issue: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
OpenAPITools/openapi-generator#25107 ·
Maintainers usually reply within 1 day
-
needs-maintainer-review review:approve
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Ultimate-Multisite/ultimate-ai-connector-compatible-endpoints#163 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day