[Bug]: Page image uploads succeed, but original and thumbnail return 404 Attachment was not found

Open
#389 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
go, sql
Domain
api, backend, database

Research direction

Start in internal/repository/attachment_repository.go, where the item download and thumbnail lookups join items and restrict entity_type, so page-scoped rows never match. Compare with internal/services/page_attachment_upload_service.go, which writes EntityType "page", and internal/services/item_attachment_service.go, which OpenItemAttachment calls. Done when a page image's content and thumbnail return 200 for authorised users while unauthorised and unrelated requests still get 404.

Written by the indexing model from the issue text.

Description

fixed-0.9.2
Summary

Page image uploads persist both the original image and its thumbnail, but opening the resulting attachment through the shared attachment binary URLs returns 404 with {"error":{"code":"not_found","message":"Attachment was not found"}}.

This appears to be a mismatch between page-scoped upload metadata and item-only retrieval. The existing binary endpoints call OpenItemAttachment, which intentionally excludes attachment rows where entity_type='page'.

Environment
  • Windshift: self-hosted Linux binary; deployment derived from v0.8.9 with a local SMTP patch. The code paths described were also inspected in the main branch (28 October 2026).
  • AWS EC2, systemd and Nginx reverse proxy.
  • Filesystem storage enabled with --attachment-path /var/lib/windshift/attachments.
  • Uploading a JPEG to a page created both a .jpeg and .thumb.jpg under attachments/pages/5/.
Steps to reproduce
  1. Start Windshift with a writable --attachment-path.
  2. As an authorised user, open a workspace page and upload/insert a JPEG image.
  3. Confirm the upload succeeds and the image and thumbnail exist under the storage root.
  4. Open the embedded image in a new tab (or request the generated /attachments/{id}/content or /thumbnail URL).
  5. Observe a 404 JSON error: Attachment was not found.
Expected

An authorised user with permission to view the owning page can retrieve the original and thumbnail inline. Unauthorised users, or requests for unrelated/nonexistent attachments, continue to receive 404. Existing work-item attachments remain unaffected.
Actual
The upload writes the files, but the binary response returns 404 not_found.

Root-cause analysis
  • internal/services/page_attachment_upload_service.go: UploadPageAttachment records EntityType: "page", ItemID: in.PageID and stores files in a pages// directory.
  • internal/restapi/v2/attachments.go: the shared /attachments/{attachment_id}/content, /download and /thumbnail routes use serveItemAttachment, calling OpenItemAttachment.
  • internal/services/item_attachment_service.go: OpenItemAttachment calls GetItemDownloadRecord / GetItemThumbnailRecord.
  • internal/repository/attachment_repository.go: both item record lookups JOIN items and explicitly restrict entity_type to item-like values. A page-scoped row can therefore never match. The resulting ErrItemAttachmentNotFound maps to the observed JSON 404.
Dominant language
Go
Stars
421
Forks
50
Avg merge
17h 34m
Merged PRs (30d)
80

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Windshiftapp/core

All issues in Windshiftapp/core

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.