[Bug]: Page image uploads succeed, but original and thumbnail return 404 Attachment was not found

Ouverte
#389 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
Une demi-journée
Accessibilité débutants
42/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Calme
Stack technique
go, sql
Domaine
api, backend, database

Piste de recherche

Start in internal/repository/attachment_repository.go, where the item download and thumbnail lookups join items and restrict entity_type, so page-scoped rows never match. Compare with internal/services/page_attachment_upload_service.go, which writes EntityType "page", and internal/services/item_attachment_service.go, which OpenItemAttachment calls. Done when a page image's content and thumbnail return 200 for authorised users while unauthorised and unrelated requests still get 404.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

fixed-0.9.2
Summary

Page image uploads persist both the original image and its thumbnail, but opening the resulting attachment through the shared attachment binary URLs returns 404 with {"error":{"code":"not_found","message":"Attachment was not found"}}.

This appears to be a mismatch between page-scoped upload metadata and item-only retrieval. The existing binary endpoints call OpenItemAttachment, which intentionally excludes attachment rows where entity_type='page'.

Environment
  • Windshift: self-hosted Linux binary; deployment derived from v0.8.9 with a local SMTP patch. The code paths described were also inspected in the main branch (28 October 2026).
  • AWS EC2, systemd and Nginx reverse proxy.
  • Filesystem storage enabled with --attachment-path /var/lib/windshift/attachments.
  • Uploading a JPEG to a page created both a .jpeg and .thumb.jpg under attachments/pages/5/.
Steps to reproduce
  1. Start Windshift with a writable --attachment-path.
  2. As an authorised user, open a workspace page and upload/insert a JPEG image.
  3. Confirm the upload succeeds and the image and thumbnail exist under the storage root.
  4. Open the embedded image in a new tab (or request the generated /attachments/{id}/content or /thumbnail URL).
  5. Observe a 404 JSON error: Attachment was not found.
Expected

An authorised user with permission to view the owning page can retrieve the original and thumbnail inline. Unauthorised users, or requests for unrelated/nonexistent attachments, continue to receive 404. Existing work-item attachments remain unaffected.
Actual
The upload writes the files, but the binary response returns 404 not_found.

Root-cause analysis
  • internal/services/page_attachment_upload_service.go: UploadPageAttachment records EntityType: "page", ItemID: in.PageID and stores files in a pages// directory.
  • internal/restapi/v2/attachments.go: the shared /attachments/{attachment_id}/content, /download and /thumbnail routes use serveItemAttachment, calling OpenItemAttachment.
  • internal/services/item_attachment_service.go: OpenItemAttachment calls GetItemDownloadRecord / GetItemThumbnailRecord.
  • internal/repository/attachment_repository.go: both item record lookups JOIN items and explicitly restrict entity_type to item-like values. A page-scoped row can therefore never match. The resulting ErrItemAttachmentNotFound maps to the observed JSON 404.
Langage dominant
Go
Étoiles
421
Forks
50
Merge moyen
17 h 34 min
PR mergées (30 j)
80

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de Windshiftapp/core

Toutes les issues de Windshiftapp/core

Issues similaires

Plus d'issues Go

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.