Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

String + struct = segfault

Open
  • Is something wrong?
#52 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
compilers

Research direction

Start in Pattern::getValue() and reproduce the failure with the provided struct and string-concatenation example in ImHex or the browser playground. Trace the cloned unique_ptr and the returned value's pointer lifetime; done means the example no longer segfaults in both environments.

Written by the indexing model from the issue text.

Description

The pattern language (both ImHex and the browser playground) will segfault upon running the following code:

struct A {};
A a;
str b = "" + a;

I debugged this a little bit, and it looks like the issue is in Pattern::getValue(). The clone() call creates a unique_ptr, which is freed when the function is done, but its pointer is left in the returned value, which is no longer valid.

Dominant language
C++
Stars
278
Forks
77
Avg merge
2d 8h
Merged PRs (30d)
7

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from WerWolv/PatternLanguage

All issues in WerWolv/PatternLanguage

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.