ws_bridge: stripping format=evr for matchmaker connections can concatenate the path and query
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 73/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cpp
- Domain
- networking
Research direction
Start with ws_bridge.cpp:1008-1020 and trace how the URI is modified for matchmaker connections. Check the existing tests for URI handling, then add coverage for a query beginning with ?format=evr&discordid=... and verify the resulting path and query remain separated.
Written by the indexing model from the issue text.
Description
Found during #41's extension (PR #109). ws_bridge.cpp:1008-1020 strips "format=evr&" from the URI for matchmaker connections (conn >= 2). If nevr_socket_uri's query starts with "?format=evr&discordid=...&password=...", stripping "format=evr&" together removes the "?" along with it: "wss://g.example/ws?format=evr&discordid=1&password=pw" becomes "wss://g.example/wsdiscordid=1&password=pw" — path and query concatenated with no separator.
Doesn't trigger with the current example config (docs/reference/example-config.yaml:175 doesn't put format=evr first), so this is latent, not necessarily hit today. Pre-existing, not introduced by #41's fix. Needs its own look at the stripping logic — probably wants to strip through the next & and reinsert a single separator, rather than assuming format=evr is removable as a prefix.
- Dominant language
- C
- Stars
- 2
- Forks
- 2
- Avg merge
- 18h 52m
- Merged PRs (30d)
- 29
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from EchoTools/nevr-runtime
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
EchoTools/nevr-runtime#117 · 2 comments ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
EchoTools/nevr-runtime#114 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 76/100
EchoTools/nevr-runtime#110 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 90/100
EchoTools/nevr-runtime#108 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
EchoTools/nevr-runtime#107 ·
Maintainers usually reply within 1 day
All issues in EchoTools/nevr-runtime
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
dkfans/keeperfx#5415 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
void-linux/void-runit#141 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ARM-software/sysarch-acs#600 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day