Contradicting `SOL_TCP` and `SOL_UDP` definition for p1

Open
#855 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

  • #876 by @Hokila — closed without merging

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Tech stack
c

Research direction

Compare the p1 declarations in libc-bottom-half/headers/public/__header_sys_socket.h with the entries in expected/wasm32-wasip1/predefined-macros.txt. First determine how the expected macro list is generated and which file defines the p1 contract. Done means resolving the source-of-truth question and making the two representations consistent, with the relevant macro-generation or validation checks passing.

Written by the indexing model from the issue text.

Description

They are not defined within the p1 scope in libc-bottom-half/headers/public/__header_sys_socket.h:
https://github.com/WebAssembly/wasi-libc/blob/0d5332aceea8e72698b6abc270550e666ba97aea/libc-bottom-half/headers/public/__header_sys_socket.h#L27-L28

But they are included in expected/wasm32-wasip1/predefined-macros.txt:
https://github.com/WebAssembly/wasi-libc/blob/0d5332aceea8e72698b6abc270550e666ba97aea/expected/wasm32-wasip1/predefined-macros.txt

Which one should be the source of truth?

Dominant language
C
Stars
1k
Forks
268
Avg merge
1d 3h
Merged PRs (30d)
20

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from WebAssembly/wasi-libc

All issues in WebAssembly/wasi-libc

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.