Contradicting `SOL_TCP` and `SOL_UDP` definition for p1
Maintainers usually reply within 1 day
Nobody has claimed this yet.
- #876 by @Hokila — closed without merging
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Active
- Tech stack
- c
- Domain
- operating-systems
Research direction
Compare the p1 declarations in libc-bottom-half/headers/public/__header_sys_socket.h with the entries in expected/wasm32-wasip1/predefined-macros.txt. First determine how the expected macro list is generated and which file defines the p1 contract. Done means resolving the source-of-truth question and making the two representations consistent, with the relevant macro-generation or validation checks passing.
Written by the indexing model from the issue text.
Description
They are not defined within the p1 scope in libc-bottom-half/headers/public/__header_sys_socket.h:
https://github.com/WebAssembly/wasi-libc/blob/0d5332aceea8e72698b6abc270550e666ba97aea/libc-bottom-half/headers/public/__header_sys_socket.h#L27-L28
But they are included in expected/wasm32-wasip1/predefined-macros.txt:
https://github.com/WebAssembly/wasi-libc/blob/0d5332aceea8e72698b6abc270550e666ba97aea/expected/wasm32-wasip1/predefined-macros.txt
Which one should be the source of truth?
- Dominant language
- C
- Stars
- 1k
- Forks
- 268
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 20
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from WebAssembly/wasi-libc
-
wasip2: enabling O_APPEND with fcntl reuses the old positional output stream and overwrites the fileOpen
Difficulty 3/5 1-2 days Newbie friendliness 70/100
WebAssembly/wasi-libc#919 ·
Maintainers usually reply within 1 day
-
wasip2/wasip3: reads never see data appended to a file after reaching EOFPossibly taken @libsmol claimed this 24 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 61/100
WebAssembly/wasi-libc#889 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
WebAssembly/wasi-libc#815 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
WebAssembly/wasi-libc#809 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
WebAssembly/wasi-libc#778 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
All issues in WebAssembly/wasi-libc
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
389ds/389-ds-base#8152 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
isolation2 lockmodes fails on cassert builds: extra AccessShareLock on partition rootPossibly taken @tuhaihe claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/cloudberry#2356 ·
Maintainers usually reply within 2 days
-
windows-artifacts: the win-arm64 job uses a Visual Studio generator missing from windows-11-armOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 91/100