blur: toggling blur back on doesn't show until the window redraws
Maintainers usually reply within 5 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 67/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cpp
- Domain
- computer-graphics, desktop
Research direction
Start in plugins/blur/blur.cpp at the toggle callback and trace how adding a blur transformer updates the view; the report says removal takes effect immediately while addition waits for a redraw. Check how nearby code schedules repaint or damage after changing transformers. Done when toggling blur back on makes it visible immediately, with a regression test or reproducible check covering both toggle directions.
Written by the indexing model from the issue text.
Description
Wayfire version: 0.11.0 (Arch Linux package wayfire 0.11.0-1)
GPU: NVIDIA GeForce RTX 2060, nvidia-open-dkms 615.78.08, kernel 7.2
What happens
With blur enabled and a mouse-button toggle bound ([blur] toggle = <super> <alt> BTN_MIDDLE), toggling blur off on a translucent window takes effect immediately, but toggling it back on does not show until the window redraws. The window stays sharp until you type in it, move it, or something else repaints it; then the blur appears.
Steps to reproduce
[blur]enabled withblur_by_default = type is "toplevel"andtoggle = <super> <alt> BTN_MIDDLE.- Open a translucent terminal (Alacritty with opacity < 1): the desktop behind it is blurred.
- Super+Alt + middle-click the terminal: the blur goes away at once (expected).
- Super+Alt + middle-click it again and leave the terminal idle: it stays sharp.
- Type a character in the terminal, or move the window a little: now the blur is back.
Expected
The blur shows right after step 4, the same way removing it shows right after step 3.
Notes
In plugins/blur/blur.cpp (v0.11.0) the toggle callback does the right thing (pop_transformer() when a blur_node_t is present, add_transformer() otherwise), so the blur node is added; it looks like adding the transformer does not schedule a repaint/damage of the view, while removing it does. Related but different from #1556 (that one was a keyboard binding on this button option).
- Dominant language
- C++
- Stars
- 3.1k
- Forks
- 247
- Avg merge
- 8d 11h
- Merged PRs (30d)
- 9
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from WayfireWM/wayfire
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
WayfireWM/wayfire#3148 · 1 comment ·
Maintainers usually reply within 5 days
-
easy enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
WayfireWM/wayfire#3005 · 14 comments ·
Maintainers usually reply within 5 days
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Maintainers usually reply within 5 days
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 53/100
WayfireWM/wayfire#3164 · 2 comments ·
Maintainers usually reply within 5 days
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
Maintainers usually reply within 5 days
All issues in WayfireWM/wayfire
Similar issues
-
[Bug] [Go] Ack returns nil when the server answers with a non-OK statusPossibly taken @leizhiyuan claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
apache/rocketmq-clients#1465 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
KhronosGroup/Vulkan-Tutorial#534 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 2 days
-
bug IO
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
MrNeRF/LichtFeld-Studio#3824 ·
Maintainers usually reply within 1 day
-
pnnx: manual tanh GELU fusion loses the approximation modePossibly taken @ktz03 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Tencent/ncnn#7175 · 1 reaction ·
Maintainers usually reply within 1 day