Lock screen crash message is vague

Open Beginner friendly
#3,005 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp
Domain
desktop

Research direction

Start at plugins/protocols/session-lock.cpp lines 190-193 and review related issues #2911 and #2998. Replace the explosion-only crash display with an informative message explaining what happened and that restarting the lock screen may be needed. Verify that the lock-screen crash path displays the updated message.

Written by the indexing model from the issue text.

Description

easy enhancement good first issue

Describe the issue

When the lock screen program crashes, an explosion image pops up, and supposedly nothing works until restarting the lock screen program. This image does not provide any information about what just happened or why it happened, and therefore confuses the user to no end.

Two computer monitors, both showing an explosion image stretched across their respective screens

Additional information

Despite being given the opportunity to show text, the author of the session lock plugin decided to only show an explosion emoji: https://github.com/WayfireWM/wayfire/blob/master/plugins/protocols/session-lock.cpp#L190-L193

Related: #2911, #2998

Dominant language
C++
Stars
3.1k
Forks
237
Avg merge
4d 36m
Merged PRs (30d)
5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from WayfireWM/wayfire

All issues in WayfireWM/wayfire

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.