`get_instruction_hash` should default to a discriminator of `0`
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
Research direction
The issue points to the Python bindings: is_instruction_collapsed in python/function.py already defaults its discriminator to 0, so start by comparing its signature with get_instruction_hash, which is in the same module. Give the discriminator parameter a default of 0 and check that a call without it matches an explicit 0. The line number in the issue may be outdated, so search for the function names rather than trusting the link.
Written by the indexing model from the issue text.
Description
As per a similar API, we should default to a discriminator of 0 as a default to make this API easier to use and for consistency's sake.
Note that GH is slow right now so I'm not sure that line number linked above is correct, but it's from the search. It's is_instruction_collapsed.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 297
- Avg merge
- 5d 3h
- Merged PRs (30d)
- 28
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Vector35/binaryninja-api
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Vector35/binaryninja-api#8621 · 1 comment ·
Maintainers usually reply within 3 days
-
ARMv7 lifting issuesOpen
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Vector35/binaryninja-api#8617 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Vector35/binaryninja-api#8589 ·
Maintainers usually reply within 3 days
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Vector35/binaryninja-api#8540 ·
Maintainers usually reply within 3 days
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Vector35/binaryninja-api#8446 ·
Maintainers usually reply within 3 days
All issues in Vector35/binaryninja-api
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
[request] vsg/1.1.16Openupstream update
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
conan-io/conan-center-index#31142 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
FISCO-BCOS/FISCO-BCOS#5684 ·
Maintainers usually reply within 4 days