normalize time logs from WARP

Open Beginner friendly
#8,446 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
rust
Domain
tooling

Research direction

Start at plugins/warp/src/plugin.rs lines 46 and 109, where the WARP timing messages are formatted. Update the output so durations use "seconds" rather than a trailing "s", and verify both loading and corresponding timing messages match the requested wording.

Written by the indexing model from the issue text.

Description

I'm doing some perf testing and it would be great if we could normalize these to also use " seconds " instead of appending "s" the way the output current does. It brings them in line with the other time stamps we use.

[WARP.Plugin] Loading files took 6.329744375s

->

[WARP.Plugin] Loading files took 6.329744375 seconds

https://github.com/Vector35/binaryninja-api/blob/dev/plugins/warp/src/plugin.rs#L46
https://github.com/Vector35/binaryninja-api/blob/dev/plugins/warp/src/plugin.rs#L109

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.