Cherry-pick: xinput1_3: Do not enumerate "disabled" controllers.
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- c
- Domain
- operating-systems
Research direction
Start by reviewing Wine merge request 12160, then locate the xinput1_3 implementation in this repository and compare the upstream change with the Proton tree. Apply the corresponding change so disabled controllers are not enumerated, and verify the result with the relevant controller behavior or tests available in the project.
Written by the indexing model from the issue text.
Description
Proton has a gamepad bug that I just fixed in Wine. Since Proton is game focused, it's pretty important to get it into Proton too, so that we'll have a world where people can disable controllers without worrying whether they're on Wine or Proton:
- Dominant language
- C
- Stars
- 2.1k
- Forks
- 504
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ValveSoftware/wine
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ValveSoftware/wine#363 · 1 reaction ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
ValveSoftware/wine#353 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
ValveSoftware/wine#303 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
ValveSoftware/wine#354 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
ValveSoftware/wine#339 · 4 comments · 1 reaction ·
All issues in ValveSoftware/wine
Similar issues
-
IO.get_env on Node truncates names at embedded NULPossibly taken @Yi-111-a claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
HigherOrderCO/Bend#1449 · 1 comment ·
-
bug C/C++ code
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
webarkit/WebARKitLib#84 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
OpenPrinting/cups#1751 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
es-ude/OnDeviceTraining#488 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day