DMA census: classify guild and vehicle-dismount interaction frames

Open
#604 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
8/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
rust

Research direction

Start from the uncovered DMA/VInt calls for Event_HuntersGuild and Event_GettingOffVehicle, traced through hunters_guild.rs, vehicles.rs, and the job-board session and dialogue/window owners. Identify which op consumes each frame on each branch, separating one-time uploads from repeated input-loop frames. Done means the US-image dma_census tests, hunters_guild_scenes, vehicle_get_off_scenes and the affected session tests pass, with a control for wrong frame ownership or double-counting.

Written by the indexing model from the issue text.

Description

later

Child of https://github.com/TusanHomichi/PSIV/issues/599. Finish only this task in one fresh session and one PR. The parent's original authorization boundaries still apply; this child grants no additional authority. Do not read earlier sessions' transcripts.

Child of TusanHomichi/PSIV#599; one PR after #595's census publication. Own Event_HuntersGuild and Event_GettingOffVehicle. Trace their uncovered DMA/VInt calls through hunters_guild.rs, vehicles.rs, the job-board session and dialogue/window owners. Name the actual op or mechanic consuming each frame on the applicable branch, distinguishing a one-time upload from an input loop's repeated frames. Add missing synchronization through the existing owner without changing job decisions, rewards, vehicle eligibility or dialogue behavior. Leave layout-refresh boundary work to #546. Original #599 authority and protected-input rules apply; preserve unrelated work and rows, read no earlier transcripts, and perform no unrelated repairs, release, deployment or asset distribution.

Verification: Run US-image dma_census tests, hunters_guild_scenes, vehicle_get_off_scenes and affected session tests through documented locks. Cover board entry/selection/cancel and successful/blocked dismount branches. Include a control rejecting incorrect frame ownership or double-counting. Verify ordinary native input for any changed interaction timing.

If this is too big, publish any progress, split it with proj split FILE (a JSON array of title/body/check tasks), then end the session. Wait for the PR to land before declaring this task done.

Dominant language
Rust
Stars
1
Forks
0
Avg merge
8h 43m
Merged PRs (30d)
288

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TusanHomichi/PSIV

All issues in TusanHomichi/PSIV

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.