DMA census: classify Garuberk and Silence Temple door frames

Open
#601 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
8/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Tech stack
godot, rust

Research direction

Wait for #595's census to publish, then read garuberk_events.rs, dezo_endgame.rs, and scene documents 103 and 116 with their runtime owners. Map each uncovered DMA/VInt call in the Garuberk door opening/entry events and the Silence Temple door opening to the door phase, wait, or movement op that spends its frame; assign layout-refresh gaps to #546. Done when every assigned row names a consuming op or #546, a control test catches a missing or double-counted frame, and the PR lands.

Written by the indexing model from the issue text.

Description

later

Child of https://github.com/TusanHomichi/PSIV/issues/599. Finish only this task in one fresh session and one PR. The parent's original authorization boundaries still apply; this child grants no additional authority. Do not read earlier sessions' transcripts.

Child of TusanHomichi/PSIV#599; deliver one PR after #595 publishes its census. Own Event_GaruberkTwDoorOpening1/2, Event_GaruberkTwDoorEntered1/2 and Event_SilenceTmDoorOpening. Read garuberk_events.rs, dezo_endgame.rs, scene documents 103 and 116, and their runtime owners. For every uncovered retail DMA/VInt call, identify the particular door phase, wait or movement op spending its frame. Account for table rows and loop repetitions rather than equating static call counts with elapsed frames. Repair only missing DMA synchronization outside #546's layout-refresh work; explicitly assign refresh-owned gaps to #546. Preserve chunk-write/collision ordering, map updates and traversal behavior. Original #599 boundaries apply: protect local inputs, preserve unrelated work, read no earlier transcripts, and perform no unrelated timing repairs, release, deployment or asset distribution.

Verification: Run US-image dma_census tests, focused Garuberk runtime tests and psiv-core's late_dezolis_scenes tests through documented locks. Check each opening/entry phase and Silence Temple table row for its expected frames and update policy. Add a control detecting a missing or double-counted frame. Assigned rows must name an actual consuming op/mechanic or explicitly identify #546 ownership.

If this is too big, publish any progress, split it with proj split FILE (a JSON array of title/body/check tasks), then end the session. Wait for the PR to land before declaring this task done.

Dominant language
Rust
Stars
1
Forks
0
Avg merge
8h 43m
Merged PRs (30d)
288

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TusanHomichi/PSIV

All issues in TusanHomichi/PSIV

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.