Scenes: retail Event_MoveCamera calls with no transcribed op (tower tops, Lashiec, Dark Force 3)

Open
  • Is something wrong?
#565 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
22/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
godot, rust
Domain
game-dev

Research direction

Start with the four call sites in dezo_endgame.rs (Event_StrengthTowerTop, Event_CourageTowerTop) and dezo_campaign_late.rs (Event_LashiecAppearance, Event_DarkForce3Defeated), and compare each against the cited ps4.asm line ranges. Each listed call needs a SceneOp::PanCamera with the retail subject and speed plus the surrounding waits, or an entry in docs/source-notes/README.md giving the reason it is omitted. Done means each scene's test drives the camera wait; the Dark Force 3 speed still has to be measured.

Written by the indexing model from the issue text.

Description

later priority: medium

Found while auditing every Event_MoveCamera call site for #267. These retail calls have no op in the port's transcription, so the camera stays where the previous op left it (and the waits around them are missing too):

Scene Retail Missing
Event_StrengthTowerTop (dezo_endgame.rs) ps4.asm:150510-150516 DoMainUpdatesLoop($3B), then pan back to Character_1's live position at speed 2; the transcription ends on the speed-8 pan
Event_CourageTowerTop (dezo_endgame.rs) ps4.asm:150672-150678 DoMainUpdatesLoop($1D), then pan back to Character_1 at speed 2
Event_LashiecAppearance (dezo_campaign_late.rs) ps4.asm:150304-150312 and after the $28-frame object loop, the second pan to ($1E0,$150) at speed 1, and the facing/DoMapUpdateLoop beats after it
Event_DarkForce3Defeated (dezo_campaign_late.rs) ps4.asm:150108-150111 pan to Character_1; no d2 is loaded, so the speed is whatever Event_GetAndRunDialogue left in d2 (to be measured)

Already documented as not drawn: Cutscene_PsycoWand (ps4.asm:154995) and Cutscene_ZioDefeated (ps4.asm:155097, :155117, #414). Event_MotaSpaceportAppearing (ps4.asm:144811, :144833) has no transcription at all.

Acceptance: each listed call is a SceneOp::PanCamera with the retail subject and speed, along with the waits around it, or the omission is recorded in docs/source-notes/README.md with a reason. Each scene's test drives the camera wait.

Dominant language
Rust
Stars
1
Forks
0
Avg merge
8h 43m
Merged PRs (30d)
288

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TusanHomichi/PSIV

All issues in TusanHomichi/PSIV

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.