Rust pack retirement: preserve overworld and map-patch checks

Open
#554 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
12/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Active
Tech stack
python, rust
Domain
game-dev

Research direction

Start with the existing Python tests test_overworld.py and test_map_patches.py, which define the checks to carry over into the owning Rust modules. The issue requires the palette pause to be lifted first and a local Phantasy Star IV ROM, so confirm both before starting. Done means the focused overworld and patch tests pass against the ROM, with Python and full-pack parity retained and failures shown for bad page addressing and patch application.

Written by the indexing model from the issue text.

Description

later

Child of https://github.com/TusanHomichi/PSIV/issues/115. Finish only this task in one fresh session and one PR. The parent's original authorization boundaries still apply; this child grants no additional authority. Do not read earlier sessions' transcripts.

After the palette pause is lifted, preserve checks from test_overworld.py and test_map_patches.py in the owning Rust modules. Reuse the patch tests already present. Keep this PR to extraction, paged layouts and patch output, without adding scene fidelity work. List every coverage disposition. Retain Python and parity; keep ROM-derived evidence local.

Verification: Run focused overworld and patch tests with the local ROM and full-pack parity. Demonstrate failures for incorrect page addressing and patch application.

If this is too big, publish any progress, split it with proj split FILE (a JSON array of title/body/check tasks), then end the session. Wait for the PR to land before declaring this task done.

Dominant language
Rust
Stars
1
Forks
0
Avg merge
8h 43m
Merged PRs (30d)
288

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TusanHomichi/PSIV

All issues in TusanHomichi/PSIV

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.