Rust pack retirement: preserve map record and emitted-map checks

Open
  • Is something wrong?
#552 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
15/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
godot, python, rust
Domain
data, testing

Research direction

Start from the parent task in TusanHomichi/PSIV#115 and the remaining checks in test_maps.py and test_pack_maps.py, then find the matching Rust tests in psiv-pack and the psiv-data consumers. Coverage for map records, encounters and emitted-map structure must be ported without changing gameplay or pack schema, and dispositions documented. Done means focused Rust map tests, runtime-pack consumer tests and full-pack parity pass with the local ROM kept out of Git, and damaged records or wrong emitted fields are shown to be rejected. The work is gated on the palette pause being lifted and is not a first-timer task.

Written by the indexing model from the issue text.

Description

later

Child of https://github.com/TusanHomichi/PSIV/issues/115. Finish only this task in one fresh session and one PR. The parent's original authorization boundaries still apply; this child grants no additional authority. Do not read earlier sessions' transcripts.

After the palette pause is lifted, preserve remaining checks from test_maps.py and test_pack_maps.py in psiv-pack and the appropriate psiv-data consumers. Cover map records, encounters and emitted-map structure, reusing current Rust tests. Document all coverage dispositions. Do not change gameplay or pack schema. Keep Python and parity until final deletion; keep ROM-derived evidence outside Git.

Verification: Run focused Rust map tests with the local ROM, relevant runtime-pack consumer tests and full-pack parity. Demonstrate rejection of damaged records or incorrect emitted fields.

If this is too big, publish any progress, split it with proj split FILE (a JSON array of title/body/check tasks), then end the session. Wait for the PR to land before declaring this task done.

Dominant language
Rust
Stars
1
Forks
0
Avg merge
8h 43m
Merged PRs (30d)
288

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TusanHomichi/PSIV

All issues in TusanHomichi/PSIV

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.