ruby: create_embedded_signature ignores fileName (upload named document.bin)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 86/100
Research direction
Locate create_embedded_signature in the Ruby SDK client files and compare its request parameters with the other language SDKs (e.g. the PHP/JavaScript implementations) to see how fileName is passed through. Forward fileName into the upload payload so the stored document name is preserved, then add a test asserting the parameter reaches the request. Done when the new test passes and the upload no longer falls back to document.bin.
Written by the indexing model from the issue text.
Description
The Ruby SDK drops fileName when calling create_embedded_signature, so the uploaded file is named document.bin. Signing still works because the type is detected from the bytes, but the stored document name and download filename are wrong. Pass fileName through as the other SDKs do, and add a test.
- Dominant language
- PHP
- Stars
- 1
- Forks
- 0
- Avg merge
- 3d 16h
- Merged PRs (30d)
- 10
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from TurboDocx/SDK
-
embed: handleTurboSignMessage header comment says the signing page posts to '*' (it never does)Opendocumentation
Difficulty 2/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
Similar issues
-
Bug Enhancement Performance
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Feature Status: Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
frontend low-priority
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
mplodowski/dynamicpdf-plugin#336 ·
Maintainers usually reply within 1 day
-
Add ZammadPossibly taken @Arslan-TR claimed this today. Openrequest
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
endoflife-date/endoflife.date#11298 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
FriendsOfFlarum/best-answer#137 ·