embed: defineTurboSignForm('my-tag') throws NotSupportedError (class already registered as turbosign-form)
Maintainers usually reply within 6 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, typescript
- Domain
- web-dev
Research direction
Start in the @turbodocx/embed package source: find where TurboSignFormElement is auto-registered as turbosign-form on import and where defineTurboSignForm() calls customElements.define. Choose one of the two documented fixes (fresh subclass per tag, or drop auto-registration), add a test that imports the package and registers a second tag such as my-tag without a NotSupportedError, then run the embed package's test suite and update the README section describing defineTurboSignForm('my-tag').
Written by the indexing model from the issue text.
Description
Importing @turbodocx/embed auto-registers TurboSignFormElement as turbosign-form. Calling defineTurboSignForm('my-tag') then runs customElements.define('my-tag', TurboSignFormElement) with the same constructor, which browsers reject with NotSupportedError. The README documents this call as the way to use a different tag name.
Fix: register a fresh subclass per tag (class extends TurboSignFormElement {}), or stop auto-registering on import. Add a test that registers a second tag after import. Update the README.
Found in the Docs #200 review (the docs note was removed there).
- Dominant language
- PHP
- Stars
- 1
- Forks
- 0
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 28
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from TurboDocx/SDK
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 6 days
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 6 days
-
embed: handleTurboSignMessage header comment says the signing page posts to '*' (it never does)Opendocumentation
Difficulty 2/5 Under an hour Newbie friendliness 82/100
TurboDocx/SDK#95 · 1 comment ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 6 days
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
landsman/adminer-desktop#206 ·
Maintainers usually reply within 1 day
-
Explosm: Cyanide & Happiness failed with: https://explosm.net/comics/latest#comic resulted in 307Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
RSS-Bridge/rss-bridge#5154 ·
Maintainers usually reply within 1 day
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
iftechfoundation/ifdb#1415 ·
Maintainers usually reply within 1 day