Newsletter send confirmation shows wrong newsletter

Open Beginner friendly
#32,851 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
63/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
node.js, typescript

Research direction

Trace the publish flow that displays the “Publishing and sending” dialog, focusing on how the selected newsletter is passed to the dialog when it differs from the default. The issue does not name a file or test, so first locate that dialog and its related tests. Done means the interim message shows the selected newsletter, while the “Boom sent” confirmation remains correct.

Written by the indexing model from the issue text.

Description

needs:triage
Issue Summary

On a site with more than one newsletter, when I send the non-default newsletter, the dialog box that says "Publishing and sending" briefly (and incorrectly) flashes the name of the default newsletter.

The newsletter is ultimately sent correctly, but briefly causes panic! :)

Steps to Reproduce
  1. Set up multiple newsletters.
  2. Draft a post and then Publish.
  3. Change the newsletter to a non-default one.
  4. Continue to publish.
  5. See that the "Sending..." box shows the wrong newsletter.
  6. The confirmation dialog box "Boom sent" seems correct.
Ghost Version

6.77.0

Node.js Version

22 LTS

How did you install Ghost?

Ubuntu self-hosted

Database type

MySQL 8

Browser & OS version

No response

Relevant log / error output

Code of Conduct
  • I agree to be friendly and polite to people in this repository
Dominant language
TypeScript
Stars
55.8k
Forks
12.1k
Avg merge
1d 5h
Merged PRs (30d)
617

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TryGhost/Ghost

All issues in TryGhost/Ghost

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.