SMSG_GARRISON_COMPLETE_MISSION_RESULT not fully readed
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- reverse-engineering, tooling
Research direction
Start in WowPacketParserModule.V7_0_3_22248/Parsers/GarrisonHandler.cs at HandleGarrisonFinishMission, especially the read reported at line 331. Reproduce the SMSG_GARRISON_COMPLETE_MISSION_RESULT packet and trace the preceding Packet.ReadUInt32 calls against the available packet data. Done means the packet is parsed without EndOfStreamException.
Written by the indexing model from the issue text.
Description
[5] FollowerDBID: 0
System.IO.EndOfStreamException
Unable to read beyond the end of the stream.
at System.IO.BinaryReader.InternalRead(Int32 numBytes)
at System.IO.BinaryReader.ReadUInt32()
at WowPacketParser.Misc.Packet.ReadUInt32(String name, Object[] indexes) in C:\Users\thord\Desktop\shadowlandsparser\WowPacketParser\Misc\PacketReads.cs:line 382
at WowPacketParserModule.V7_0_3_22248.Parsers.GarrisonHandler.HandleGarrisonFinishMission(Packet packet) in C:\Users\thord\Desktop\shadowlandsparser\WowPacketParserModule.V7_0_3_22248\Parsers\GarrisonHandler.cs:line 331
at WowPacketParser.Parsing.Handler.Parse(Packet packet, Boolean isMultiple) in C:\Users\thord\Desktop\shadowlandsparser\WowPacketParser\Parsing\Handler.cs:line 149
- Dominant language
- C#
- Stars
- 522
- Forks
- 387
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from TrinityCore/WowPacketParser
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
TrinityCore/WowPacketParser#990 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
TrinityCore/WowPacketParser#953 ·
-
3.4.3.55392 Open
Difficulty 4/5 3-5 days Newbie friendliness 20/100
TrinityCore/WowPacketParser#866 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
TrinityCore/WowPacketParser#836 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
TrinityCore/WowPacketParser#833 ·
All issues in TrinityCore/WowPacketParser
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nightscout/nocturne#1425 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
RayWangQvQ/BiliBiliToolPro#1137 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100