`SMSG_VENDOR_INVENTORY` undefined for 3.4.1/3.4.2 builds.

Open
#836 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
devtools, reverse-engineering

Research direction

Start by tracing where SMSG_VENDOR_INVENTORY is defined and resolved for the 3.4.1 and 3.4.2 builds, then compare those definitions with the 3.4.0 module mentioned in the report. Done means both builds recognize the opcode and parse its structure correctly; the issue does not name a file or test to run.

Written by the indexing model from the issue text.

Description

I did try to manually define the opcode for 3.4.1 (0x25B9 iirc) using the 3.4.0 module, but the structure was also incorrect, and I don't know enough at this time to be able to fix it myself unfortunately.

Dominant language
C#
Stars
522
Forks
387
Avg merge
3d 6h
Merged PRs (30d)
4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TrinityCore/WowPacketParser

All issues in TrinityCore/WowPacketParser

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.