Remove nullables from IDataModels

Open
#220 0 comments 0 reactions 1 assignee View on GitHub

@Carbenium is already working on this.

Since Dec 29, 2015.

Assessment

This issue has not been assessed yet.

Description

enhancement

The IDataModels in https://github.com/TrinityCore/WowPacketParser/tree/master/WowPacketParser/Store/Objects after 3ddbce572bddaf79c3d570cf406cc98d927acbad are using a lot of nullables which make the API a bit clumsy to use and in most cases the null fields do not make any sense, e.g, what does it mean having a CreatureTemplate object with Entry set to null?

@Carbenium can give more info on this

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29428522-remove-nullables-from-idatamodels?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github).
Dominant language
C#
Stars
522
Forks
387
Avg merge
3d 6h
Merged PRs (30d)
4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TrinityCore/WowPacketParser

All issues in TrinityCore/WowPacketParser

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.