Remove nullables from IDataModels
@Carbenium is already working on this.
Since Dec 29, 2015.
Assessment
This issue has not been assessed yet.
Description
The IDataModels in https://github.com/TrinityCore/WowPacketParser/tree/master/WowPacketParser/Store/Objects after 3ddbce572bddaf79c3d570cf406cc98d927acbad are using a lot of nullables which make the API a bit clumsy to use and in most cases the null fields do not make any sense, e.g, what does it mean having a CreatureTemplate object with Entry set to null?
@Carbenium can give more info on this
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29428522-remove-nullables-from-idatamodels?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github).- Dominant language
- C#
- Stars
- 522
- Forks
- 387
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from TrinityCore/WowPacketParser
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
TrinityCore/WowPacketParser#990 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
TrinityCore/WowPacketParser#953 ·
-
3.4.3.55392 Open
Difficulty 4/5 3-5 days Newbie friendliness 20/100
TrinityCore/WowPacketParser#866 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
TrinityCore/WowPacketParser#836 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
TrinityCore/WowPacketParser#833 ·
All issues in TrinityCore/WowPacketParser
Similar issues
-
type/automation type/tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
t/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
ci-failure-cause test-failure
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area:auth FE mvp P3
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
klasolsson81/jobbliggaren#1788 ·