Document that matching removes highlights from footnotes

Open Beginner friendly
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
78/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript
Domain
documentation

Research direction

Read the "What gets copied" section of docs/SPEC.md to confirm the null-highlight behavior, then open the "How it works" section of README.md. Add one or two sentences saying that highlight color is copied and that a match from an unhighlighted footnote removes highlights from all footnotes. Done when the README describes what the spec says, with no code changes.

Written by the indexing model from the issue text.

Description

documentation good first issue

Summary

By design (see docs/SPEC.md, "What gets copied"), when the source character has no highlight, BACKGROUND_COLOR is saved as null and applying the style removes highlights from all footnotes. This includes highlights a user added on purpose to particular footnotes.

The behavior is intended, but the README doesn't mention it, so it may surprise users.

Suggested change

Add a sentence to the "How it works" section of README.md, e.g.: "Highlight color is copied too. If the footnote you match from has no highlight, highlights are removed from all footnotes."

Optionally, consider whether the add-on should leave highlights alone instead (a behavior change that would need a spec update).


Generated by Claude Code

Dominant language
JavaScript
Stars
0
Forks
0
Avg merge
6m
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Tanman310/footnote-matcher

All issues in Tanman310/footnote-matcher

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.