Error alert says nothing changed after a partial update
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- frontend
Research direction
The alert text is set in runWithFriendlyErrors_ in src/Code.js, and applyStyleToFootnotes_ is the function that can fail partway through. Read how the catch path builds the message, then change the wording so it no longer says nothing was changed. Done means a failure after some footnotes were restyled shows the suggested or an equivalent message. No test is named, so check the failure path by hand in the add-on.
Written by the indexing model from the issue text.
Description
Summary
When a menu action fails, runWithFriendlyErrors_ shows: "Nothing else was changed. Please try again." If the error happens partway through applyStyleToFootnotes_, the footnotes processed before the failure have already been restyled, so the message can be wrong.
(Errors inside a single paragraph are already caught and counted, so this mainly affects failures outside that loop.)
Suggested fix
Reword the alert so it doesn't promise that nothing changed. For example: "Some footnotes may already have been updated. You can run the command again, or use Edit → Undo to revert."
Relevant code: runWithFriendlyErrors_ in src/Code.js.
Generated by Claude Code
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 6m
- Merged PRs (30d)
- 4
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Tanman310/footnote-matcher
-
documentation good first issue
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
bug
Difficulty 3/5 Half a day Newbie friendliness 48/100
All issues in Tanman310/footnote-matcher
Similar issues
-
accessibility area: css area: web ui bug difficulty: easy frontend good first issue help wanted javascript journey: first-visit journey: mobile priority: P3 quality tech: css tech: html typescript ui user-experience
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
themactep/thingino-firmware#2018 ·
Maintainers usually reply within 1 day
-
[analytics-core] getQueryParams does not decode `+` as space and truncates values containing `=`Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
amplitude/Amplitude-TypeScript#2179 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
cloudinary/js-url-gen#608 ·
-
ci: raise .github/workflows/test.yml timeout-minutes from 20 to 35 as suite exceeds 30,899 testsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Jason-Vaughan/TangleClaw#3075 ·
Maintainers usually reply within 1 day