Publish v2 on NPM for React 18 Peer Dependency

Open
#630 8 comments 8 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
react, typescript
Domain
frontend

Research direction

Start with duplicate issue #568 and the linked discussion about publishing #278. Verify the package metadata and release path for [email protected], then reproduce the React 18 installation command. Done means the v2 package is published on NPM and npm resolves its React 18 peer dependency without the reported ERESOLVE failure.

Written by the indexing model from the issue text.

Description

Describe the bug

Currently, running npm install react-virtual on a project with React 18 fails because of unresolved peer dependency.

Duplicate of #568 to publish #278 on NPM - comment

Your minimal, reproducible example

https://tanstack.com/table/v8/docs/examples/react/virtualized-infinite-scrolling

Steps to reproduce
  1. npm init -y
  2. npm install react@18 react-virtual
Expected behavior

npm to resolve dependency properly

How often does this bug happen?

Always 🤖

Screenshots or Videos
knitevision1@knitevision1-laptop:~/dev/pg/qwe$ npm install react@18 react-virtual
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"18" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.6.3 || ^17.0.0" from [email protected]
npm ERR! node_modules/react-virtual
npm ERR!   react-virtual@"^2.10.4" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /home/knitevision1/.npm/_logs/2023-11-28T09_59_36_731Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /home/knitevision1/.npm/_logs/2023-11-28T09_59_36_731Z-debug-0.log
Platform

Linux

tanstack-virtual version

2.10.4

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct
  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Dominant language
TypeScript
Stars
7.2k
Forks
495
Avg merge
23h 16m
Merged PRs (30d)
19

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TanStack/virtual

All issues in TanStack/virtual

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.