laneAssignmentMode 'measured': is it intended that a row measured at exactly its estimate can change lanes?
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start in tests/index.test.ts, which the issue names as the place that reads the private measurement method, and trace how resizeItem handles sizes equal to estimateSize in measured lane assignment. Add a regression case based on the reproducer, then check whether lanes remain stable after row 1 grows; the issue leaves the intended behavior unresolved, so confirm that before changing behavior.
Written by the indexing model from the issue text.
Description
Describe the bug
With lanes > 1 and laneAssignmentMode: 'measured', a row whose first measurement exactly equals estimateSize doesn't get its lane cached, because resizeItem records a measurement only when the size changes. When a row above it grows later, that row is placed again and can move to another lane. A row measured at any other size keeps its lane.
Your minimal, reproducible example
import { Virtualizer } from '@tanstack/virtual-core'
const measureThenGrow = (height: number) => {
const virtualizer = new Virtualizer({
count: 8,
lanes: 2,
estimateSize: () => 100,
laneAssignmentMode: 'measured',
getScrollElement: () => null,
scrollToFn: () => {},
observeElementRect: () => {},
observeElementOffset: () => {},
})
// getMeasurements is private; tests/index.test.ts reads it the same way.
const lanes = () =>
virtualizer['getMeasurements']().map((m) => m.lane).join(' ')
lanes() // Build the measurements first; resizeItem needs them.
for (let i = 0; i < 8; i++) virtualizer.resizeItem(i, height)
const measured = lanes()
virtualizer.resizeItem(1, 500)
return { measured, grown: lanes() }
}
console.log(measureThenGrow(100))
// { measured: '0 1 0 1 0 1 0 1', grown: '0 1 0 0 0 0 1 0' }
console.log(measureThenGrow(101))
// { measured: '0 1 0 1 0 1 0 1', grown: '0 1 0 1 0 1 0 1' }
Steps to reproduce
- Run the example above.
- At 100, row 1 growing moves rows 3, 5, 6 and 7 to another lane.
- At 101, every row keeps its lane.
Expected behavior
I can't tell which behavior is intended, so I'd like to ask before going further.
- If this is not intended, a row measured at exactly its estimate should keep its lane like any other measured row, since the docs say lanes are cached and remain stable after the initial measurement. #1377 is a draft of that fix.
- If this is intended, for example so that a placeholder sized like the estimate can rebalance once its content loads, there is nothing to fix and I'll close #1377.
Is this behavior intended?
How often does this bug happen?
Every time
Platform
Any. This is in virtual-core.
tanstack-virtual version
3.19.11
TypeScript version
n/a
Terms & Code of Conduct
- I agree to follow this project's Code of Conduct
- I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 495
- Avg merge
- 23h 16m
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from TanStack/virtual
-
With `useScrollendEvent`, scrollToIndex and scrollToEnd stop short when the target moves while they settlePossibly taken @Darkatse claimed this 8 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Maintainers usually reply within 1 day
-
svelte-virtual renders no rows when the scroll element is bound after the store subscribesPossibly taken @clean99 claimed this 13 days ago. Open
Difficulty 4/5 1-2 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
anchorTo: 'end' does not keep the reading position when only paddingStart changesPossibly taken @duongynhi000001-crypto claimed this 12 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 30/100
Maintainers usually reply within 1 day
-
anchorTo: 'end' loses the end when the scroll element shrinksPossibly taken @langleyd claimed this 41 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
marko-virtual: scrollToEnd during an in-flight prepend strands the view one prepend above the bottom (chat-pretext e2e fails on CI)Possibly taken @officialasishkumar claimed this 15 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
All issues in TanStack/virtual
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 83/100
gofish-graphics/gofish-graphics#1384 ·
Maintainers usually reply within 1 day
-
adapter bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Olanetsoft/agent-lookout#353 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
vicharanashala/vibe#1542 ·
Maintainers usually reply within 1 day
-
bug chore P2 size:XS
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
josephfung/curia#2666 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
devarshishimpi/codra#178 ·
Maintainers usually reply within 1 day