Separate the Cloudflare peer pin for plain Vite integration

Open
#166 0 comments 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript, vite

Research direction

Read the package peer dependency metadata and compare it with the /vite and /cloudflare adapter entry points linked in the issue. Reproduce the strict peer installation failure with pnpm using the versions provided; then identify a compatibility policy that keeps the /cloudflare adapter's exact runtime check intact. Done means plain /vite consumers can install a supported combination without weakening that check.

Written by the indexing model from the issue text.

Description

Description

@tanstack/[email protected] declares the optional peer @cloudflare/vite-plugin: "1.65.0" at package level. This also applies to applications using only @tanstack/redact/vite alongside the official Cloudflare Vite plugin, without importing @tanstack/redact/cloudflare.

As a result, strict peer installation fails for that integration with @cloudflare/[email protected].

I checked the separate /cloudflare adapter: it vendors a maintained 1.65.0 integration and intentionally checks that exact version. I am not requesting that its runtime guard be removed or that all Cloudflare v2 versions be declared compatible.

The distinction is that the plain /vite adapter uses Vite hooks and does not import the Cloudflare plugin.

Steps to Reproduce

In an empty directory, use:

{
  "private": true,
  "dependencies": {
    "@tanstack/redact": "0.3.1",
    "@cloudflare/vite-plugin": "2.0.0-beta.v.11",
    "vite": "8.3.6"
  }
}

Run:

pnpm install --lockfile-only --strict-peer-dependencies --ignore-scripts

This fails before either adapter is imported.

The intended application setup uses these two independent imports:

import { redact } from '@tanstack/redact/vite'
import { cloudflare } from '@cloudflare/vite-plugin'

Expected Behavior

A compatibility policy for the plain /vite integration that is separate from the vendored /cloudflare adapter's exact peer requirement.

For example, a separately packaged adapter could retain its narrow peer range, or supported plain-Vite combinations could be documented/tested while retaining the exact runtime check on /cloudflare. I would welcome the maintainers' preferred approach rather than assuming a blanket peer-range expansion is safe.

Actual Behavior

Verified with pnpm 12.18.0:

[ERR_PNPM_PEER_DEP_ISSUES] Unmet peer dependencies
✕ unmet peer @cloudflare/vite-plugin
  Installed: 2.0.0-beta.v.11
  Wanted:
    1.65.0:
      @tanstack/[email protected]

An optional peer still produces this conflict when the application explicitly installs a different version.

Environment

  • @tanstack/redact: 0.3.1
  • @cloudflare/vite-plugin: 2.0.0-beta.v.11
  • Plain Vite 8.3.6 for the isolated peer reproduction
  • Node 26.13.0, pnpm 12.18.0, macOS 27.2 arm64
  • Application integration: TanStack Start, native RSC, React/React DOM 19.3.1, @vitejs/[email protected], Vite+ 1.5.0 (Vite 8.3.5)

Additional Context

In the application, we scoped a pnpm peer correction to the exact version tested:

overrides:
  '@tanstack/[email protected]>@cloudflare/vite-plugin:peer': '1.65.0 || 2.0.0-beta.v.11'

There was also a separate dev SSR optimizer issue, so the metadata override alone is not sufficient evidence of compatibility. Redact excludes the aliased React peers from optimization; the RSC client's CommonJS vendor then retained require("react-dom") in Cloudflare's neutral SSR optimizer.

We resolved that locally with:

import { esmExternalRequirePlugin } from 'vite' // also exported by vite-plus

// within the Vite configuration:
environments: {
  ssr: {
    optimizeDeps: {
      rolldownOptions: {
        plugins: [
          esmExternalRequirePlugin({ external: ['react', 'react-dom'] }),
        ],
      },
    },
  },
},

This keeps the RSC environment on native React and leaves Redact's shared runtime aliases/exclusions in place. With both local changes, the application passed dev SSR/hydration, navigation and Devtools smoke checks, plus preview builds. That is evidence for this specific combination, not a general v2 support claim.

I reported the optimizer behavior separately at https://github.com/cloudflare/workers-sdk/issues/16769, with a framework-free reproduction. It also reproduces on the newer Cloudflare beta 2.0.0-beta.v.12 and plain Vite 8.3.6. An integration note linking the required optimizer handling would also help plain-Vite consumers while that is investigated.

Dominant language
TypeScript
Stars
581
Forks
28
Avg merge
13h 48m
Merged PRs (30d)
45

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TanStack/redact

All issues in TanStack/redact

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.