Separate the Cloudflare peer pin for plain Vite integration

オープン
#166 コメント 0 件 リアクション 1 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
typescript, vite

調査の方向性

Read the package peer dependency metadata and compare it with the /vite and /cloudflare adapter entry points linked in the issue. Reproduce the strict peer installation failure with pnpm using the versions provided; then identify a compatibility policy that keeps the /cloudflare adapter's exact runtime check intact. Done means plain /vite consumers can install a supported combination without weakening that check.

索引モデルが issue の本文から書いたものです。

説明

Description

@tanstack/[email protected] declares the optional peer @cloudflare/vite-plugin: "1.65.0" at package level. This also applies to applications using only @tanstack/redact/vite alongside the official Cloudflare Vite plugin, without importing @tanstack/redact/cloudflare.

As a result, strict peer installation fails for that integration with @cloudflare/[email protected].

I checked the separate /cloudflare adapter: it vendors a maintained 1.65.0 integration and intentionally checks that exact version. I am not requesting that its runtime guard be removed or that all Cloudflare v2 versions be declared compatible.

The distinction is that the plain /vite adapter uses Vite hooks and does not import the Cloudflare plugin.

Steps to Reproduce

In an empty directory, use:

{
  "private": true,
  "dependencies": {
    "@tanstack/redact": "0.3.1",
    "@cloudflare/vite-plugin": "2.0.0-beta.v.11",
    "vite": "8.3.6"
  }
}

Run:

pnpm install --lockfile-only --strict-peer-dependencies --ignore-scripts

This fails before either adapter is imported.

The intended application setup uses these two independent imports:

import { redact } from '@tanstack/redact/vite'
import { cloudflare } from '@cloudflare/vite-plugin'

Expected Behavior

A compatibility policy for the plain /vite integration that is separate from the vendored /cloudflare adapter's exact peer requirement.

For example, a separately packaged adapter could retain its narrow peer range, or supported plain-Vite combinations could be documented/tested while retaining the exact runtime check on /cloudflare. I would welcome the maintainers' preferred approach rather than assuming a blanket peer-range expansion is safe.

Actual Behavior

Verified with pnpm 12.18.0:

[ERR_PNPM_PEER_DEP_ISSUES] Unmet peer dependencies
✕ unmet peer @cloudflare/vite-plugin
  Installed: 2.0.0-beta.v.11
  Wanted:
    1.65.0:
      @tanstack/[email protected]

An optional peer still produces this conflict when the application explicitly installs a different version.

Environment

  • @tanstack/redact: 0.3.1
  • @cloudflare/vite-plugin: 2.0.0-beta.v.11
  • Plain Vite 8.3.6 for the isolated peer reproduction
  • Node 26.13.0, pnpm 12.18.0, macOS 27.2 arm64
  • Application integration: TanStack Start, native RSC, React/React DOM 19.3.1, @vitejs/[email protected], Vite+ 1.5.0 (Vite 8.3.5)

Additional Context

In the application, we scoped a pnpm peer correction to the exact version tested:

overrides:
  '@tanstack/[email protected]>@cloudflare/vite-plugin:peer': '1.65.0 || 2.0.0-beta.v.11'

There was also a separate dev SSR optimizer issue, so the metadata override alone is not sufficient evidence of compatibility. Redact excludes the aliased React peers from optimization; the RSC client's CommonJS vendor then retained require("react-dom") in Cloudflare's neutral SSR optimizer.

We resolved that locally with:

import { esmExternalRequirePlugin } from 'vite' // also exported by vite-plus

// within the Vite configuration:
environments: {
  ssr: {
    optimizeDeps: {
      rolldownOptions: {
        plugins: [
          esmExternalRequirePlugin({ external: ['react', 'react-dom'] }),
        ],
      },
    },
  },
},

This keeps the RSC environment on native React and leaves Redact's shared runtime aliases/exclusions in place. With both local changes, the application passed dev SSR/hydration, navigation and Devtools smoke checks, plus preview builds. That is evidence for this specific combination, not a general v2 support claim.

I reported the optimizer behavior separately at https://github.com/cloudflare/workers-sdk/issues/16769, with a framework-free reproduction. It also reproduces on the newer Cloudflare beta 2.0.0-beta.v.12 and plain Vite 8.3.6. An integration note linking the required optimizer handling would also help plain-Vite consumers while that is investigated.

主要言語
TypeScript
スター
581
フォーク
28
平均マージ
13時間 48分
マージ済み PR(30日)
45

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/redact のほかの issue

TanStack/redact の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。