[angular-query] injectDevtoolsPanel doesn't support the 'theme' option
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- angular, typescript
Research direction
Inspect the angular-query implementation of injectDevtoolsPanel and its DevtoolsPanelOptions type; compare them with withDevtools and the React, Preact, Solid, and Vue panels. Done means TypeScript accepts theme: 'dark' and the Angular panel applies the selected theme, with relevant existing checks passing.
Written by the indexing model from the issue text.
Description
Describe the bug
injectDevtoolsPanel doesn't accept a theme option. withDevtools and the React/Preact/Solid/Vue panels all support it.
I think it was missed in #10609, which added theme only to the floating Angular devtools.
Your minimal, reproducible example
injectDevtoolsPanel(() => ({
hostElement: this.divEl(),
theme: 'dark', // TS error: 'theme' does not exist in type 'DevtoolsPanelOptions'
}))
Steps to reproduce
- Use
injectDevtoolsPanel - Pass
theme: 'dark' - Get a type error, and the theme is not applied
Expected behavior
injectDevtoolsPanel accepts theme like withDevtools does. I can send a PR for this.
Platform
- OS: macOS
- Browser: any
Tanstack Query adapter
angular-query
TanStack Query version
5.104.0 (also current main)
- Dominant language
- TypeScript
- Stars
- 50.4k
- Forks
- 4.2k
- Avg merge
- 17h 50m
- Merged PRs (30d)
- 297
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from TanStack/query
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
TanStack/query#11358 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
TanStack/query#11106 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
TanStack/query#11663 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
TanStack/query#11642 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 74/100
TanStack/query#11639 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
refactor
Difficulty 2/5 Half a day Newbie friendliness 84/100
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
OHDSI/Data2Evidence#3450 ·
Maintainers usually reply within 2 days
-
e2e-failure ready-to-code
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
redhat-developer/rhdh-plugin-export-overlays#4011 · 1 comment ·
Maintainers usually reply within 1 day
-
automation missing-model model-sync provider:ofox
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
anomalyco/models.dev#8421 ·
Maintainers usually reply within 1 day
-
SlackAdapter and TelegramAdapter are not assignable to Adapter under exactOptionalPropertyTypesOpen
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day