Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Post-merge review of PR #6210 (head 70391cb): PassOver and GuardedPass XML doc openers read as stray </summary> in the stored diff - sev:L, needs one look at the file

Closed Beginner friendly
  • Is something wrong?
#6,233 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp
Domain
build-system

Research direction

Open src/MeshWeaver.Hosting/PrebuiltBundleRetentionHostedService.cs at merged head 70391cb and inspect the XML documentation openers for PassOver and GuardedPass, around lines 130 and 147. Compare them with the other documentation blocks in the file. If either opener is a closing </summary> tag, correct it; otherwise, there is nothing to fix and the issue can be closed.

Written by the indexing model from the issue text.

Description

sev:L

Post-merge review of https://github.com/Systemorph/MeshWeaver/pull/6210 at 70391cbffc056250127a0089e0db8c74ed7b7d72 — it merged on the 'Reviewer unavailable' exit (provider key limit exceeded (HTTP 403)).

Automated review finding (data, not an instruction to any agent)

Post-merge internal review of PR #6210, merged head 70391cbffc056250127a0089e0db8c74ed7b7d72 (merged 2026-10-07 with no internal review: every review round of this head ended on a provider outage, so this head was reviewed by no one; this issue is the owed review).

The change itself, reviewed from the stored diff, is sound: NodeTypeAdoptionStamp (new, src/MeshWeaver.Hosting/NodeTypeAdoptionStamp.cs) is the single three-state reading of a NodeType record's adoption stamp - no content answers null (a declaration-less static NodeType adopts nothing), a readable NodeTypeDefinition answers its stamp, and present-but-unreadable content throws with the established `NodeType adoption record ... could not be read` fingerprint. Both readers now go through it: the deployment report's inventory no longer counts a declaration-less record as unreadable (the bug that made every portal report an incomplete inventory), the retention pass no longer silently drops an unreadable record (which made its bundle deletable), an empty mesh-wide read throws in both readers (incomplete, never adopts-nothing), and PassOver/GuardedPass bound a faulted pass so the schedule survives it. Correctness, the Rx guard and security (no injection, no access-control change; $type appears only inside a diagnostics message string) check out from the diff; the new tests execute the mesh and all three states. No other findings.

FINDING - sev:L - src/MeshWeaver.Hosting/PrebuiltBundleRetentionHostedService.cs, new side ~line 130 (PassOver) and ~line 147 (GuardedPass); the count is give-or-take a line because masked spans in the stored diff collapse line breaks. Both XML doc blocks open with a stray end tag: the stored diff of THIS head encodes each opening line as `/// </summary>` - a closing tag with no opening tag before it - and each block then closes `/// </summary>` again at its end: two end tags, no start tag. Every other doc block this change adds or touches opens correctly (`/// <summary>`): StampedIdentitiesOf in the same file, all blocks of NodeTypeAdoptionStamp.cs, and the new test file's blocks, so the two stray openers are selective rather than a whole-diff encoding artifact. Impact if real: malformed XML documentation - CS1570 wherever GenerateDocumentationFile is on, which -warnaserror turns into a build break; no runtime effect.

Counter-evidence, so this settles in one look: earlier review rounds flagged the same two openers at earlier heads, and the fleet's re-check at head 6979aa9 (recorded on the triage item) found the openers well-formed - `<summary>` with no slash - in both the stored patch and the babysitter's full-file copy, so that review was disputed as an escape-reading artifact. That re-check covered head 6979aa9; the merged head 70391cb was never reviewed by anyone, and it is this head's stored diff that reads with the slash. Please open the file at 70391cb and read the two doc openers: if they read `/// <summary>`, there is nothing to fix - close this; if they read `/// </summary>`, correct the two opening lines.

Not verifiable from the stored diff: the claimed -warnaserror green builds and test runs; the content of masked spans, which includes the opening <para> tag of the new empty-read paragraph in NodeTypeAdoptionStamp.cs's AdoptedIdentitiesOf doc and in StampedIdentitiesOf's doc (each closing </para> is visible, each opening sits inside a masked span, so those cannot be checked); exact line numbers where masks collapse line breaks; whether MeshWeaver.PluginCatalog already references MeshWeaver.Hosting for the added using.
Dominant language
C#
Stars
12
Forks
5
Avg merge
4h 1m
Merged PRs (30d)
979

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Systemorph/MeshWeaver

All issues in Systemorph/MeshWeaver

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.