Remember position and video-offset change when working between multiple files

Open
#16,597 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
desktop-dev

Research direction

The bug is about per-file playback position and video offset being lost when switching between open subtitle files, and it is also not remembered when a file is reopened in the same session. Start by looking for where the video offset and playback position are stored and restored when a subtitle file is opened or switched in the desktop UI. Reproduce by opening a .srt, changing the offset, switching to another file, and returning. Done when the offset survives the round trip within a session.

Written by the indexing model from the issue text.

Description

MacOS (Intel) in 5.0.4-rc2
When I swap between files (one .ass and one .srt) the .srt file "forgets" that the video offset has been changed. The first video startet at 10:00:00:00, so that was the offset. The new video starts at 09:59:30:00. When I re-open the .srt file after having a different file opened, it is back at 10:00:00:00. When I close and open SE, it seems to "remember" correctly.

Also, when I re-open a file without closing and re-opening SE, the position is not remembered.

Dominant language
C#
Stars
14.8k
Forks
1.4k
Avg merge
1h 1m
Merged PRs (30d)
668

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SubtitleEdit/subtitleedit

All issues in SubtitleEdit/subtitleedit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.