Feature Request: Color for length/cps that is over certain threshold but not in the limit yet
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
Research direction
The request is to add a warning color for subtitle line length and characters-per-second when a line is close to the limit but not over it, matching the yellow used by the user-defined regex rules. Start by reading how the user-defined error rules and their colors are handled in the C# codebase, and check the existing CPS and line-length limit checks. Before coding, confirm with the maintainers how the threshold should be configured, since the issue leaves that open.
Written by the indexing model from the issue text.
Description
In the user defined error rules (which are great!) it's not possible to measure cps. I would greatly appreciate it if I could label subtitle lenghts that do not exceed the defined limit but come close to it. Same as in the user defined regex rules, I would prefer not to use the (red) error color (as it's not an error by definition) but the same as in the user defined rules (in my case that would be yellow).
In practical terms that would be very helpful as compared to just lowering the actual limit, as those would not show up in error reports and I can already think ahead for projects where the main movie is 24fps but the TV version is 25fps and therefore some subtitles would then exceed the limits in the broadcast version.
Thank you for considering that.
- Dominant language
- C#
- Stars
- 14.8k
- Forks
- 1.4k
- Avg merge
- 1h 1m
- Merged PRs (30d)
- 668
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SubtitleEdit/subtitleedit
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
SubtitleEdit/subtitleedit#16374 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
SubtitleEdit/subtitleedit#14510 · 3 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
SubtitleEdit/subtitleedit#16609 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
SubtitleEdit/subtitleedit#16608 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
SubtitleEdit/subtitleedit#16597 ·
Maintainers usually reply within 1 day
All issues in SubtitleEdit/subtitleedit
Similar issues
-
area/resource-registry status/triage
Difficulty 1/5 1-3 hours Newbie friendliness 76/100
Altinn/altinn-auth#4821 ·
Maintainers usually reply within 1 day
-
a11y community:contribution
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
microsoft/fluentui-blazor#5590 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
JetBrains/resharper-unity#2510 ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
QuantConnect/Documentation#2838 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
AvaloniaUI/Avalonia#22697 · 1 comment ·
Maintainers usually reply within 1 day