Bug report: Window position & size not imported/reset; "Apply" button issues during settings import

Open
#16,413 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
47/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
desktop

Research direction

Start by tracing the settings import and reset flow, then inspect how the Main Window and Settings Window save and restore geometry and how the Apply and OK actions handle layout and UI language. Reproduce the reported behavior in Subtitle Edit 5.4.0 Beta 7 on Windows 11. Done means importing or resetting settings updates window geometry, and Apply followed by OK preserves imported layout and language changes.

Written by the indexing model from the issue text.

Description

When importing settings or resetting to default, several inconsistencies occur regarding window geometry, UI language changes, and the behavior of the "Apply" button.

1. Window Position & Size (Import & Reset):

  • Import: The window position and size of both the Main Window and the Settings Window are not loaded/changed when importing settings. (Other windows might be affected as well).
  • Reset: Resetting settings does not reset the size and position of the Main Window and Settings Window.
  • (Note: The Options > "Shortcuts" and "Word lists" windows correctly update on both import and reset).

2. Import Behavior ("Apply" vs. "OK"):
When importing settings (after selecting the file and checking the items to import):

  • Layout adjustments for the Main Window are only applied if you click "OK". If you click "Apply" and then "OK", the layout changes are not applied at all.
  • Similarly, changing the UI Language via import is not applied immediately when clicking "Apply".

Environment:

  • OS: Windows 11
  • Subtitle Edit Version: 5.4.0 Beta 7
Dominant language
C#
Stars
14.8k
Forks
1.4k
Avg merge
1h 1m
Merged PRs (30d)
668

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SubtitleEdit/subtitleedit

All issues in SubtitleEdit/subtitleedit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.