Optional dependencies don't participate in extension invalidation
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
Research direction
Start with the linked photon-mosaic issue 182 for the original context, then trace where child dependencies are registered during import and how extension invalidation handles parameter-dependent dependencies. The open pull request 4913 indicates work is already underway; completion should cover invalidation when those dependencies change based on parameters.
Written by the indexing model from the issue text.
Description
See original issue on photon-mosaic: https://github.com/photon-mosaic/photon-mosaic/issues/182
TLDR; children dependencies are only registered at import time, failing to catch param-dependent dependencies
- Dominant language
- Python
- Stars
- 870
- Forks
- 284
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 41
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SpikeInterface/spikeinterface
-
core
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
SpikeInterface/spikeinterface#4914 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
SpikeInterface/spikeinterface#4842 · 3 comments ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SpikeInterface/spikeinterface#4510 · 2 comments ·
Maintainers usually reply within 1 day
-
MountainSort5: expose `pca_seed` / `random_seed` sorter param (pair with MS5 configurable PCA seed)Open
Difficulty 4/5 3-5 days Newbie friendliness 43/100
SpikeInterface/spikeinterface#4919 ·
Maintainers usually reply within 1 day
-
BaseSorting.select_periods() drops properties, annotations and the registered recordingPossibly taken @AxelNoun claimed this today. Openbug core
Difficulty 2/5 1-3 hours Newbie friendliness 20/100
SpikeInterface/spikeinterface#4915 · 3 comments ·
Maintainers usually reply within 1 day
All issues in SpikeInterface/spikeinterface
Similar issues
-
request-theme
Difficulty 1/5 Under an hour Newbie friendliness 78/100
LizardByte/ThemerrDB#9883 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Project-MONAI/MONAI#9258 ·
Maintainers usually reply within 3 days
-
catalog:deprecation
Difficulty 1/5 Under an hour Newbie friendliness 88/100
surendranb/free-inference#31 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
fritzprix/libr-agent#2612 ·
Maintainers usually reply within 1 day
-
needs-triage presubmit-gate
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
gke-labs/kube-agents#5001 ·
Maintainers usually reply within 1 day