combine_probes lose 'device_channel_indices'

Open
#431 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
backend-api-design

Research direction

Start with the multi-shank probe example in the linked documentation and inspect the combine_probes function around the mentioned line 89 TODO. Trace how device_channel_indices is handled when probes are combined, then add regression coverage for the two-shank case. Done means the resulting combined probe retains the expected device_channel_indices.

Written by the indexing model from the issue text.

Description

I followed this doc to create a multi-shank probe.
However, the resulting two-shank probe does not has 'device_channel_indices'. Could anyone suggeset how to fix this issue?
I checked the function there was a comment at line 89 saying

# TODO deal with contact_ids/device_channel_indices

so I dont know what's the best way to approach this issue

Image

probeinterface version 0.3.2

Dominant language
Python
Stars
85
Forks
49
Avg merge
13h 47m
Merged PRs (30d)
3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SpikeInterface/probeinterface

All issues in SpikeInterface/probeinterface

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.