GenericWrite ACL not collected on OU

Open
#38 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
security

Research direction

Start in src/CommonLib/Processors/ACLProcessor.cs around lines 338-392 and compare how GenericAll, WriteDACL, WriteOwner, GenericWrite, and WriteProperty are collected for different object types. Use the linked Active Directory exploitation articles for context on OU permissions. Done means GenericWrite and WriteProperty ACLs on OUs are collected consistently with the stated behavior.

Written by the indexing model from the issue text.

Description

The ACL Processor collects GenericAll, WriteDACL and WriteOwner ACLs on all object types.

For GenericWrite and WriteProperty, it collects the ACLs only for User, Group and Computer (and to some extent GPOs):

https://github.com/BloodHoundAD/SharpHoundCommon/blob/a2cc6c1bff4e3879c9329e89822d7e82e6806911/src/CommonLib/Processors/ACLProcessor.cs#L338-L392

I just stumbled upon a case where an Everyone has GenericWrite on an OU, this can be exploited as shown in the following articles:

I think this edge should also be collected on OUs. What do you think?

Thanks a lot for your great work!

Dominant language
C#
Stars
104
Forks
56
Avg merge
3d 23h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SpecterOps/SharpHoundCommon

All issues in SpecterOps/SharpHoundCommon

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.