NuGet version 4.3.1 does not appear to contain code added prior to release on Aug 4th

Open
#245 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
release

Research direction

Compare the published SharpHoundCommon NuGet 4.3.1 package with the c25048c commit, focusing on ACLProcessor and the referenced CalculateImplicitACLHash and IsAdminSDHolderProtected members. Confirm whether the package contains the pre-release code and document whether the version was built from the wrong source.

Written by the indexing model from the issue text.

Description

The 4.3.1 release of SharpHoundCommon in NuGet does not contain several ACLProcessor functions/members required by the current SharpHound legacy codebase. This is confusing because the c25048c commit on July 29th adds the required/missing code (specifically CalculateImplicitACLHash and IsAdminSDHolderProtected). Is it possible an incorrect version of the codebase was added to NuGet under the 4.3.1 label?

Dominant language
C#
Stars
104
Forks
56
Avg merge
3d 23h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SpecterOps/SharpHoundCommon

All issues in SpecterOps/SharpHoundCommon

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.