Filter out GPOs with disabled computer settings from local group processing

Open
#85 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp
Domain
security

Research direction

Start in src/CommonLib/Processors/GPOLocalGroupProcessor.cs at ReadGPOLocalGroups, linked in the issue. Review how linked GPOs are processed for local-group edges, then exclude GPOs that are disabled or have computer settings disabled. Done means those GPOs no longer contribute local-group processing results.

Written by the indexing model from the issue text.

Description

We check if principals are added to local groups such as Administrators through linked GPOs and create edges like AdminTo based on that with the function ReadGPOLocalGroups: https://github.com/BloodHoundAD/SharpHoundCommon/blob/ed7b3916d304c9dba901cf58876607bb0576610e/src/CommonLib/Processors/GPOLocalGroupProcessor.cs#L63

We should filter out GPOs that are either disabled or have their computer settings disabled as those GPOs will not apply to computers:
image

Issue originally posted here: https://github.com/BloodHoundAD/BloodHound/issues/699

Dominant language
C#
Stars
104
Forks
56
Avg merge
3d 23h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SpecterOps/SharpHoundCommon

All issues in SpecterOps/SharpHoundCommon

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.