Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Move patch/redirect/mod.rs's inline test modules into sibling test files

Closed Beginner friendly
  • Is something wrong?
#1,011 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
tooling

Research direction

Start at crates/socket-patch-core/src/patch/redirect/mod.rs: production code ends at L7622, and mod tests runs L7623–L21402 plus five more #[cfg(test)] modules down to L21936. Move each module body verbatim into a sibling file (redirect/tests.rs, python_lock_warning_tests.rs, etc.), declaring them as #[cfg(test)] mod ...; from mod.rs, using use super::* for visibility and the existing *_equivalence_tests.rs files (L33–L49) as the pattern. Done when cargo test -p socket-patch-core redirect:: shows 307/322 tests passing as before, cargo clippy -p socket-patch-core --all-targets is clean, and git diff --color-moved=zebra shows only moved blocks.

Written by the indexing model from the issue text.

Description

agent:triaged arch-audit priority:p3 refactor

[agent] Filed by the scheduled architecture audit routine (ecosystems and formats). Register: register comment.

Kind: refactor. Source: §3.7 #1 (step 1 of tracking #1010). Register E30.

Problem

About two thirds of patch/redirect/mod.rs (21,936 lines at db83f01) is inline tests:

  • mod tests, L7623–L21402: 13,780 lines and 307 tests (322 across all six modules), covering every ecosystem's rewriter;
  • python_lock_warning_tests (L21403), python_metadata_pairing_tests (L21445), hatch_tests (L21546), hosted_patch_uuid_tests (L21665) and superseding_repin_tests (L21792–L21936).

The production code ends at L7622. The sibling *_equivalence_tests.rs files already use the sibling-file pattern (L35–L45).

Impact
  • Each hosted test addition creates a conflict hotspot in the same file as the production code.
  • Production review is buried in a 22K-line file.
  • This is the cheapest step of the split, and it removes about 14.3K lines from mod.rs without touching a production line.
Proposed change
  • Declare the modules from mod.rs and move each one's body verbatim into its own file: #[cfg(test)] mod tests; → redirect/tests.rs, and likewise python_lock_warning_tests.rs, python_metadata_pairing_tests.rs, hatch_tests.rs, hosted_patch_uuid_tests.rs and superseding_repin_tests.rs.
  • Inside each file, use super::* keeps the same visibility, so no item changes visibility.
  • Optional, in a follow-up and not this PR: split tests.rs per ecosystem once the production split (later steps of #1010) lands.

Deleted from mod.rs: L7623–L21936.

Size and scope
  • Files: redirect/mod.rs and six new sibling files.
  • About 14.3K moved lines, 0 changed production lines, and about 12 added declaration lines.
  • Out of scope: any production move, any test edit or rename, and the equivalence suites.
Acceptance criteria
  • git diff --color-moved=zebra shows only moved blocks, plus the six mod declarations.
  • mod.rs is ≤ ~7.7K lines.
  • cargo test -p socket-patch-core redirect:: runs the same number of tests before and after (307 in tests and 322 across the six modules), and all of them pass.
  • cargo clippy -p socket-patch-core --all-targets is clean (no new unused warnings from the move).
Dependencies

None. It is best landed when few PRs touching redirect/mod.rs tests are open, because open PRs will need a trivial rebase onto the moved file. It is step 1 of #1010 and unblocks nothing technically, but it makes steps 2–7 reviewable.

Dominant language
Rust
Stars
8
Forks
0
Avg merge
19h 21m
Merged PRs (30d)
421

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SocketDev/socket-patch

All issues in SocketDev/socket-patch

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.