Slather incompatible with Variant tests
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- ruby
- Domain
- testing-qa
Research direction
Start by reading the binary discovery path around find_binary_files and how Slather accepts test binary paths. The issue gives no file or test names, so locate the relevant implementation and tests first. Done means variant test binaries can be selected explicitly and coverage runs against the intended variant.
Written by the indexing model from the issue text.
Description
We are using variant testing in some of our test plans (for example: one plan requiring USan and another using ASan), which results in the following Build directory structure:
Build/Products/Variant-ASan-UBSan/Debug-iphonesimulator/CTUtilsTest.xctest
Build/Products/Variant-USan-UBSan/Debug-iphonesimulator/CTUtilsTest.xctest
In this case the find_binary_files fails to find the variants (reasonable, since there's no way to tell it which one to choose anyway). This problem may be especially acute if using build_without_testing, since you're guaranteed to have the variants carried along in that case.
I've not found a way to be more specific about the binaries in order to accommodate this, so we're running a separate set of coverage tests (which should yield the same results) with a single test binary, as opposed to requiring the variants. However, there may be others who run into this in the future, and I figured I'd see if I could save someone time at least in acknowledging this.
I'm not sure exactly what the fix is here, other than to provide a way to specify variants explicitly.
- Dominant language
- Ruby
- Stars
- 1.6k
- Forks
- 239
- Avg merge
- 10h 19m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SlatherOrg/slather
-
2.8.6: NoMethodError "undefined method 'first'" in profdata_coverage_dir whenever --scheme is usedOpen
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
SlatherOrg/slather#586 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
SlatherOrg/slather#582 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
SlatherOrg/slather#580 · 9 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 56/100
SlatherOrg/slather#578 · 3 comments · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
SlatherOrg/slather#577 ·
All issues in SlatherOrg/slather
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 8 days
-
bug: "Conversation information" accordion renders blank with 0px height when conversation has no attributesPossibly taken @gihovani claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 2 days
-
`hanami generate repository` would be a nice alias for `hanami generate repo`Possibly taken @sandbergja claimed this today. Openbug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
hanami/hanami-cli#455 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
asciidoctor/asciidoctor#4882 · 4 comments ·