Slather and DataDog CI collide due to searching for CodeCoverage directories
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- ruby
- Domain
- testing-qa
Research direction
The issue points to lib/slather/project.rb lines 214–226 and provides a fork commit with a proposed change. Read that code and compare it with the linked commit, then check how the CodeCoverage framework is handled when locating binaries. Done means the reported Datadog framework no longer triggers the old Xcode coverage folder handling; the payload names no test file to run.
Written by the indexing model from the issue text.
Description
So DataDog has a Swift Test Optimization SDK which happens to have an internal framework named CodeCoverage.
This code in project.rb does not like this framework as it thinks it's an old Xcode CodeCoverage data folder: https://github.com/SlatherOrg/slather/blob/d0d5dd0e725459949f218f24556e388e6683e16e/lib/slather/project.rb#L214-L226
this leads to errors like:
slather-2.8.4/lib/slather/project.rb:607:in `find_binary_files': No product binary found in fastlaneDerivedDataOutput/Build/Products/Debug-iphonesimulator/DatadogSDKTesting.framework/Frameworks/CodeCoverage.framework/CodeCoverage. (StandardError)
I've got a fork with this change in it: https://github.com/SlatherOrg/slather/commit/da5f8e0bb49c65e4a3545b66accc20ced4b664cd
This seems to fix it but I'm not a ruby dev and I don't know this library much at all.
- Dominant language
- Ruby
- Stars
- 1.6k
- Forks
- 239
- Avg merge
- 10h 19m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SlatherOrg/slather
-
2.8.6: NoMethodError "undefined method 'first'" in profdata_coverage_dir whenever --scheme is usedPossibly taken @MirekNalepa claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
SlatherOrg/slather#586 · 4 comments · 4 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
SlatherOrg/slather#582 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
SlatherOrg/slather#580 · 9 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 56/100
SlatherOrg/slather#578 · 3 comments · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
SlatherOrg/slather#576 · 2 comments ·
All issues in SlatherOrg/slather
Similar issues
-
feature
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
manyfold3d/manyfold#7346 · 1 comment ·
Maintainers usually reply within 1 day
-
🐞 bug pending triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
CircuitVerse/CircuitVerse#8025 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
we-promise/sure#4199 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
riscv/riscv-unified-db#2738 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
scanaislop/aislop#482 ·
Maintainers usually reply within 1 day