Present, Draw and Persona successes pin an orange alert in the menu-bar panel
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 22/100
Research direction
The panel's orange row is driven by StageKitController.notices (around :497-501) and StageNotice (:683-686) in StageKitController.swift, rendered in WorkbenchQuickPanel.swift at :142 and :316-325. Success notices are raised at call sites in AppCoordinator.swift, DemoScenes.swift, SceneSharing.swift, Persona.swift and StageKitController.swift:407. Start by adding a tone to StageNotice and checking the NoticeOwnerTests expectations. Done when a nil-completed screenshot leaves no panel notice, errors and copyBoard with no board remain problems, and the mutation check fails when the filter is removed.
Written by the indexing model from the issue text.
Description
Outcome: routine successes stay on their page. The panel's orange recovery row shows only problems, and a stale success can no longer hide a live one.
Evidence (main edc15df)
StageKitController.noticesmerges notices with no tone (:497-501; StageNotice :683-686).- The panel turns any stage notice into an orange warning row (WorkbenchQuickPanel.swift:142, :316-325).
- Successes are posted as notices at:
- AppCoordinator.swift:406, 428 and 460-461
- DemoScenes.swift:499, 645, 677 and 972
- SceneSharing.swift:17 and 37
- StageKitController.swift:407
- Persona.swift:707, 752 and 1337
- A Draw success takes precedence over a later Live Camera failure.
- This conflicts with docs/workbench.md:119 (Fit 7) and #134 T5.
Change
- Give StageNotice a tone (problem by default).
- Add
post(_:on:tone:). The screenshot completion splits onerror == nil. - Scenes and personas get
noticeIsDone(reset in didSet) plusconfirm(_:), used only for the listed successes. - The panel-facing
noticetakes the first problem. Pages keep every notice.
Acceptance
NoticeOwnerTests:
- a nil-completed screenshot leaves no panel notice, while the Draw page keeps it;
- an error is a problem;
copyBoardwith no board is still a problem;- a done notice does not hide a scene problem;
saveMyDeviceis done.- Mutation check: these tests fail when the filter is removed.
Value before scope
- Outcome: a presenter sees only real problems. Evidence: the call sites above.
- Simpler route: classify where each notice is raised.
- Owner: StageKitController notices.
- Complexity: one tone field.
- Verified by: StageKitLegacy tests.
Grammar: Quality.
Refs #134
Build-ready record from the overnight lead session of 15 Oct 2026, verified against main edc15df by an independent skeptic per item. Implementation follows on a claude/* branch; this issue closes only after native acceptance.
- Dominant language
- Swift
- Stars
- 0
- Forks
- 1
- Avg merge
- 8h 5m
- Merged PRs (30d)
- 215
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Ship-Work/workbench
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
documentation good first issue help wanted
Difficulty 2/5 Half a day Newbie friendliness 74/100
Ship-Work/workbench#29 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
Maintainers usually reply within 1 day
All issues in Ship-Work/workbench
Similar issues
-
addition
Difficulty 1/5 Under an hour Newbie friendliness 82/100
jaywcjlove/awesome-mac#3621 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SwiftKickMobile/skai#84 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
bangumi/Bangumi-iOS#225 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
raullenchai/Rapid-MLX#4889 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Maintainers usually reply within 1 day