CuArray(sol) scalar-indexes GPU arrays for SecondOrderODEProblem (ArrayPartition) solutions
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
The issue is in the CuArray constructor for solutions of SecondOrderODEProblem where states are ArrayPartitions of CuArrays. Start by examining the CuArray constructor in RecursiveArrayTools.jl and how it handles AbstractVectorOfArray with ArrayPartition elements. The failing test is in test/GPU/ode_gpu.jl; run it to see the scalar indexing error. Look at the difference between ODEProblem and SecondOrderODEProblem solutions. The fix must avoid scalar indexing while preserving allowscalar(false).
Written by the indexing model from the issue text.
Description
CuArray(sol) for the solution of a SecondOrderODEProblem on CUDA arrays scalar-indexes the GPU arrays and errors under the default allowscalar(false). The solution's states are ArrayPartitions of CuArrays. The plain ODEProblem case (Array(sol) with CuArray states) works.
test/GPU/ode_gpu.jl was written for this (https://discourse.julialang.org/t/results-of-secondorderodeproblem-give-error-this-object-is-not-a-gpu-array/82100), but no test group ever included it. https://github.com/SciML/RecursiveArrayTools.jl/pull/659 wires it into the GPU group, and the self-hosted GPU job fails there: https://github.com/SciML/RecursiveArrayTools.jl/actions/runs/35874813098/job/107236637535
using CUDA, LinearAlgebra, OrdinaryDiffEq, Test
u0 = cu(rand(100)); du0 = cu(rand(100)); A = cu(randn(100, 100))
f(ddu, du, u, p, t) = mul!(ddu, A, u)
sol = solve(SecondOrderODEProblem(f, du0, u0, (0.0f0, 1.0f0)), Tsit5())
@test SciMLBase.successful_retcode(sol) # passes
CuArray(sol) # errors
Expression: size(CuArray(sol), 1) == 200
Scalar indexing is disallowed.
Invocation of getindex resulted in scalar indexing of a GPU array.
The failing versions are those resolved by that CI job: CUDA 6.4, OrdinaryDiffEq 7.8.1, RecursiveArrayTools master (4.5.2). Julia 1 is on the self-hosted GPU runner. I have not reproduced it locally because this machine has no GPU. A CPU substitute with JLArrays and allowscalar(false) did not reproduce it for JLArray(sol), so the scalar path may be specific to the CuArray constructor on AbstractVectorOfArray{<:Any,<:Any,<:ArrayPartition}.
#659 stays open as the regression test for this. Its test must not be weakened to make it pass.
🤖 Filed by Claude Code 2.1.280 (model claude-opus-5-5[1m]) from the qa-hygiene goal cycle.
- Dominant language
- Julia
- Stars
- 233
- Forks
- 76
- Avg merge
- 5h 33m
- Merged PRs (30d)
- 11
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SciML/RecursiveArrayTools.jl
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
SciML/RecursiveArrayTools.jl#255 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
SciML/RecursiveArrayTools.jl#661 ·
-
JET: similar_type(::Any) no-matching-method in RecursiveArrayToolsRaggedArrays (pre-existing QA red) Open
Difficulty 4/5 3-5 days Newbie friendliness 48/100
SciML/RecursiveArrayTools.jl#620 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
SciML/RecursiveArrayTools.jl#619 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
SciML/RecursiveArrayTools.jl#570 ·
All issues in SciML/RecursiveArrayTools.jl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
interpolate! from a Float32 LatitudeLongitudeGrid fails on Metal: Float64 division in find_λ_range Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CliMA/Oceananigans.jl#6056 ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
JuliaPluto/PlutoPlotly.jl#72 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
epiforecasts/BVDOutbreakSize#811 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
SciML/NonlinearSolve.jl#1310 · 1 comment ·