QA: ExplicitImports no_implicit_imports findings (root + RecursiveArrayToolsRaggedArrays)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start with test/QA/qa.jl and lib/RecursiveArrayToolsRaggedArrays/test/qa/qa.jl, then inspect the whole-module using statements and the related ExplicitImports findings. Run the QA environments to confirm no_implicit_imports is clean, then remove :no_implicit_imports from each ei_broken record.
Written by the indexing model from the issue text.
Description
The ExplicitImports check_no_implicit_imports check is currently marked @test_broken (ei_broken = (:no_implicit_imports,)) in two QA environments:
RecursiveArrayTools(root,test/QA/qa.jl)RecursiveArrayToolsRaggedArrays(lib/RecursiveArrayToolsRaggedArrays/test/qa/qa.jl)
Both modules rely on whole-module using of dependencies (LinearAlgebra, SymbolicIndexingInterface, ArrayInterface, StaticArraysCore, Adapt, ...) that implicitly bring dozens of names into scope. Making every used name an explicit import is a sizable source refactor that is out of scope for the QA harness conversion (run_qa v1.6 + ExplicitImports), so the check is tracked as @test_broken here rather than hard-failing the QA lane.
Resolution: convert the whole-module using X statements to explicit using X: a, b, c imports of the names actually used, then drop :no_implicit_imports from each env's ei_broken.
This issue is auto-tracking: run_qa's ei_broken records Broken while the finding stands and flips to an Unexpected Pass (error) once the check is clean, prompting removal of the marker.
- Dominant language
- Julia
- Stars
- 234
- Forks
- 77
- Avg merge
- 22h 29m
- Merged PRs (30d)
- 13
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SciML/RecursiveArrayTools.jl
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
SciML/RecursiveArrayTools.jl#255 ·
Maintainers usually reply within 1 day
-
JET: similar_type(::Any) no-matching-method in RecursiveArrayToolsRaggedArrays (pre-existing QA red)Open
Difficulty 4/5 3-5 days Newbie friendliness 48/100
SciML/RecursiveArrayTools.jl#620 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
SciML/RecursiveArrayTools.jl#570 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 28/100
SciML/RecursiveArrayTools.jl#522 ·
Maintainers usually reply within 1 day
-
tagbot-manual
Difficulty 1/5 Under an hour Newbie friendliness 45/100
SciML/RecursiveArrayTools.jl#512 ·
Maintainers usually reply within 1 day
All issues in SciML/RecursiveArrayTools.jl
Similar issues
-
Hydraulic gas_pressure omits the reference-density offset, breaking roundtrips and the pressure joinOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Bump compat of CSVOpen
Difficulty 1/5 Under an hour Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
JuliaSymbolics/Symbolics.jl#2046 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
JuliaGaussianProcesses/KernelFunctions.jl#609 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day