stage 2 cannot review the first bash call of a session
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
Research direction
Start by reading inspectShellSession and the shellSessions handling in the host code; the issue says the fix requires a fork change and fork sync. Reproduce the first-call path where inspection returns undefined, then check that stage 2 can review the command using the session shell or its starting environment. Done means the first bash call can be reviewed without being blocked solely because no shell exists yet.
Written by the indexing model from the issue text.
Description
The first bash call of a session skips stage 2: inspectShellSession returns undefined while shellSessions is empty, so there is no shell to read PATH or aliases from.
call 1 tar -xf a.tar -C out ─▶ stage 1 UNSURE ─▶ stage 2 skipped ("no shell yet") ─▶ blocked
call 2 ls out ─▶ SAFE, shell now exists
call 3 tar -xf a.tar -C out ─▶ stage 1 UNSURE ─▶ reviewer allows ─▶ runs
Seen in the live run for https://github.com/STRML/omp-classifier/issues/258: the same tar was blocked as call 1 ("skipped":"the session's shell cannot be inspected (no shell yet, or it is busy)") and ran as a later call.
Fix is on the host: inspectShellSession would create the session shell for the key when none exists, or report the env it would start with. It needs a fork change and a fork-sync.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 49m
- Merged PRs (30d)
- 82
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from STRML/omp-classifier
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
STRML/omp-classifier#256 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
STRML/omp-classifier#253 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
STRML/omp-classifier#252 ·
Maintainers usually reply within 1 day
All issues in STRML/omp-classifier
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
langchain-ai/langchainjs#12239 ·
Maintainers usually reply within 1 day
-
Board view: the Monitoring column is always empty because compact issue rows drop displayStatusOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
paperclipai/paperclip#21837 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
code-yeongyu/senpi#6813 ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 93/100
lingdojo/kana-dojo#34169 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100