The shell snapshot is hashed, then reopened to source it
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 52/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- bash, typescript
Research direction
Read the fork change in PR #255, especially commits 8c443d04d3 and b1c5e383c2, and trace pin_snapshot through run_setup. Reproduce the timeout-triggered rebuild and inspect how the snapshot is hashed and sourced. Done means the session executes the exact bytes that were hashed, so a file swap cannot leave snapshotChanged false.
Written by the indexing model from the issue text.
Description
The fork's pin_snapshot hashes the shell snapshot, then source reopens the file by path. A writer that lands between the two during a core rebuild gets its bytes sourced under a hash that says nothing changed, so snapshotChanged stays false and the gate keeps reviewing.
rebuild (after a timeout) ─▶ hash snapshot ─▶ (writer swaps file) ─▶ source <path> ─▶ baseline taken
▲ window: the start of run_setup
Exploiting it needs a write to $TMPDIR/omp-shell-snapshots-<uid>/ racing a core rebuild, which the agent can force with a timeout. The window is the gap between two syscalls, not a review round trip.
Fix: read the snapshot bytes once and source exactly those bytes (feed them to the session as a script rather than source '<path>'), so the pin and the sourced text cannot diverge.
Found by the Opus security review of the fork change for https://github.com/STRML/omp-classifier/pull/255 (fork commits 8c443d04d3 and b1c5e383c2).
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 49m
- Merged PRs (30d)
- 82
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from STRML/omp-classifier
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
STRML/omp-classifier#259 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
STRML/omp-classifier#253 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
STRML/omp-classifier#252 ·
Maintainers usually reply within 1 day
All issues in STRML/omp-classifier
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
langchain-ai/langchainjs#12239 ·
Maintainers usually reply within 1 day
-
Board view: the Monitoring column is always empty because compact issue rows drop displayStatusOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
paperclipai/paperclip#21837 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
code-yeongyu/senpi#6813 ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 93/100
lingdojo/kana-dojo#34169 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100