Ignore node_modules when linting

Open
  • Is something wrong?
#3 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
cli, tooling

Research direction

Start by tracing the lint-no-exit-ts task and its gulp-tslint configuration; the reported failure comes from node_modules/http-status-enum/src/index.ts. The completed change should prevent dependency files under node_modules from being linted, allowing the development build to proceed without reporting their lint errors.

Written by the indexing model from the issue text.

Description

When re-using a node module, one does not have control over the packages while implementing the Rocketlet.
The dev-environment refusing the build due to linting errors, particularly in dependencies is not satisfying.

[09:53:41] 'lint-no-exit-ts' errored after 3.77 s
[09:53:41] Error in plugin 'gulp-tslint'
Message:
  /.../temporary-rocketlets-dev-environment/rocketlets/smarti/node_modules/http-status-enum/src/index.ts [43, 35]: Missing trailing comma.
Dominant language
TypeScript
Stars
49
Forks
40
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat.Apps-cli

All issues in RocketChat/Rocket.Chat.Apps-cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.