ignoredFiles are not ignored
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- cli
Research direction
Start in src/compiler/getAppSource.ts at the linked line and trace how ignoredFiles from .rcappsconfig is passed into the file-selection logic. Confirm the behavior with a .vscode/** entry and verify that TypeScript files under .vscode are excluded.
Written by the indexing model from the issue text.
Description
When I add .vscode/** in the ignoredFiles of .rcappsconfig, Typescript files in this directory are not ignored. (I use the Local History addons in VSCode, which adds local versions of files in the .vscode directory).
I tracked down the error to this line:
https://github.com/RocketChat/Rocket.Chat.Apps-compiler/blob/f574fffd9a7c40fca2d963979f02a3023a5e2a1e/src/compiler/getAppSource.ts#L14
This line should use ignoredFiles instead.
- Dominant language
- TypeScript
- Stars
- 49
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from RocketChat/Rocket.Chat.Apps-cli
-
Feature Request: Add Boilerplate Templates to rc-apps createPossibly taken @ShubhamS2005 claimed this 243 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 55/100
RocketChat/Rocket.Chat.Apps-cli#181 · 1 comment ·
-
Windows: rc-apps deploy fails with File 'X.ts' not found while tsc compiles successfullyPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
RocketChat/Rocket.Chat.Apps-cli#177 · 3 comments ·
-
Bug: Infinite loop in rc-apps watchMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
`rc-apps pack` throws error with nodejs 24May be free again @okayxsh claimed this 231 days ago, and no pull request is open. Open
Difficulty 3/5 1-2 days Newbie friendliness 64/100
RocketChat/Rocket.Chat.Apps-cli#173 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
All issues in RocketChat/Rocket.Chat.Apps-cli
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
open-webui/tether#52 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
voidzero-dev/void#835 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
AykutSarac/jsoncrack.com#616 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
melgarafael/DeskcommCRM#4679 ·
Maintainers usually reply within 1 day