[Bug] Stress period climate adjustment factors are not ingested/applied to data
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
This issue has not been assessed yet.
Description
Summary
When running ReEDS with climate impacts to hydropower or cooling water turned ON (i.e. GSw_ClimateHydro == 1 and/or GSwClimateWater == 1), climate adjustment factors for hydropower capacity factors and unappropriated freshwater seasonal distribution factors are not being read and applied for the stress periods.
Details:
The files not being read in and applied are the versions of climate_hydadjsea.csv and climate_UnappWaterSeaAnnDistr.csv found in the stress period folders of a ReEDS run (inputs_case/stress{model_year}i{iteration}). These files contain the stress-period values of the respective data they represent, and thus, should be read in alongside the representative period versions of the file, similar to cf_hyd and other similar parameters in 2_temporal_params.gms
In the above example, without stress period data in the climate_hydro_seasonal parameter, Lines 490-491 calculates the non-dispatchable stress period data in cf_hyd as 0 for all years after the GSw_ClimateStartYear designation (see screenshot of inputs.gdx below):
Solution (ToDo):
- Adjust
2_temporal_params.gmsto read in both versions of theclimate_{hydadjsea|UnappWaterSeaAnnDistr}.csvfrom theinputs/{temporal_inputs|stress}/folders.- Change
climate_hydro_seasonalandwatsa_climatefrom a GAMStabletoparameter(required for multi-source parameter definition) - Fix
reeds/input_processing/hourly_writetimeseries.pyto outputclimate_hydadjsea.csvandclimate_UnappWaterSeaAnnDistr.csvin long format with*appended to front of first column name
- Change
- Dominant language
- Python
- Stars
- 38
- Forks
- 18
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 12
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ReEDS-Model/ReEDS
-
FINITO
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ReEDS-Model/ReEDS#250 ·
Maintainers usually reply within 3 days
-
project
Difficulty 5/5 Over a week Newbie friendliness 25/100
ReEDS-Model/ReEDS#238 · 1 reaction ·
Maintainers usually reply within 3 days
-
discuss
Difficulty 5/5 Over a week Newbie friendliness 35/100
ReEDS-Model/ReEDS#234 ·
Maintainers usually reply within 3 days
-
Geothermal techs are missing regional capital cost multipliersPossibly taken @savanthongvanh claimed this 8 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
ReEDS-Model/ReEDS#233 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 5/5 Over a week Newbie friendliness 28/100
ReEDS-Model/ReEDS#225 ·
Maintainers usually reply within 3 days
All issues in ReEDS-Model/ReEDS
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
MystenLabs/MemWal#1163 · 2 comments ·
Maintainers usually reply within 1 day
-
infertopics leaves new nodes without a topic when untopiced neighbours outnumber topiced onesPossibly taken @moneebullah25 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ClanGenOfficial/clangen#6254 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FinanceFlash/unvibecode#218 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day