Cylinder: circle mode keeps the larger diameter

Open Beginner friendly
  • Is something wrong?
#312 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, unity
Domain
game-dev

Research direction

Find the cylinder code that handles turning Elliptical off and the related tests. Read the diameter handling and add or update the test for this behavior. Done means the single diameter uses the larger of X and Z, and the test passes.

Written by the indexing model from the issue text.

Description

When Elliptical is turned off, a cylinder's X and Z become one diameter, and today that is X. Use the larger of X and Z, so the shape doesn't suddenly shrink.

Test: turning Elliptical off keeps the larger diameter.

Dominant language
C#
Stars
135
Forks
15
Avg merge
31m
Merged PRs (30d)
138

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RadicalCSG/com.chisel

All issues in RadicalCSG/com.chisel

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.